From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751066AbdGNS2A (ORCPT ); Fri, 14 Jul 2017 14:28:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:45596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdGNS16 (ORCPT ); Fri, 14 Jul 2017 14:27:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACEC922CA1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 14 Jul 2017 14:27:56 -0400 From: Steven Rostedt To: Francis Deslauriers Cc: mhiramat@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] kprobe: Fix: add symbols to kprobe blacklist Message-ID: <20170714142756.7f7f1745@gandalf.local.home> In-Reply-To: <1500044315-9508-1-git-send-email-francis.deslauriers@efficios.com> References: <1500044315-9508-1-git-send-email-francis.deslauriers@efficios.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jul 2017 10:58:33 -0400 Francis Deslauriers wrote: > Kretprobe on ftrace_ops_assist_func and another function: > Those crashes are triggered when hooking a kretprobe on the > ftrace_ops_assist_func symbol and some other functions to make the this first > function reacheable. From my understanding, ftrace_ops_assist_func is the > function called directly when the kprobe is hit. Thus it should be marked > with NOKPROBE_SYMBOL. > Hmm, I'm wondering if I should just make an ftrace section, and black list the entire thing. Also that section could be used to not allow ftrace to use it either. I've been wanting to start letting ftrace trace the tracing code, and perf for that matter. It would be nice to be able to debug things like that. I would like to also make sections that can be enabled or disabled in groups. To group things like the tracing facility and perf and have them by default not be traced, but then set a flag that says "sure go ahead and trace them". This shouldn't be too hard to do. Hmm, I'll add this as another topic to have for the Linux Plumbers tracing track, as well as the kernel tracing topic. -- Steve