From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
Date: Mon, 17 Jul 2017 12:04:15 +0100 [thread overview]
Message-ID: <20170717110415.ecavjnwcjwkd4a4b@dell> (raw)
In-Reply-To: <20170623082940.24917-1-hdegoede@redhat.com>
On Fri, 23 Jun 2017, Hans de Goede wrote:
> The PMIC provides ACPI OpRegions which must be available for other
> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
> Kconfig help text already states.
>
> Somehow its Kconfig option ended up being a tristate though, this fixes
> this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Note, feel free to squash this in the original commit if you wish
Looks like the original commit is yet to be accepted.
Please ensure it's squashed in and resubmit.
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8533cb46a875..be962d128f31 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
> on these systems.
>
> config INTEL_SOC_PMIC_CHTWC
> - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
> + bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
> depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
> depends on X86 || COMPILE_TEST
> select MFD_CORE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-07-17 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 8:29 [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool Hans de Goede
2017-07-13 8:06 ` Lee Jones
2017-07-17 11:04 ` Lee Jones [this message]
2017-07-21 22:16 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717110415.ecavjnwcjwkd4a4b@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).