From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbdGQOz4 (ORCPT ); Mon, 17 Jul 2017 10:55:56 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39113 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdGQOzz (ORCPT ); Mon, 17 Jul 2017 10:55:55 -0400 X-ME-Sender: X-Sasl-enc: UITcqYeI4fSm3ogcQvSkzfuvK1wWmXGHUh40aRtH4sTl 1500303354 Date: Mon, 17 Jul 2017 16:55:50 +0200 From: Greg Kroah-Hartman To: Johannes Poehlmann Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov Subject: Re: [PATCH v2 1/4] w1: ds1wm: fix and simplify register access Message-ID: <20170717145550.GC7084@kroah.com> References: <6a03463f-7e93-8ee7-d56f-aaed1e2befba@izt-labs.de> <1498214835-11186-2-git-send-email-johannes.poehlmann@izt-labs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498214835-11186-2-git-send-email-johannes.poehlmann@izt-labs.de> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2017 at 12:47:12PM +0200, Johannes Poehlmann wrote: > o Replace incorrect register offsett calculation by > direct configuration of bus_shift in mfd-cell. > Indirect definition of address-shift by resource size > was unobvious and should have used a binary log. > o Make endian clean, make HW-endianness configurable. > o Use ioread*, iowrite* instead of __raw_readb,__raw_writeb > to also use memory-barriers when accessing HW-registers. > We do not want reordering to happen here. > > Signed-off-by: Johannes Poehlmann > Acked-by: Evgeniy Polyakov > > 78 6 drivers/w1/masters/ds1wm.c > 9 0 include/linux/mfd/ds1wm.h And again, something went wrong here :(