From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbdGSGXz (ORCPT ); Wed, 19 Jul 2017 02:23:55 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55857 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdGSGXv (ORCPT ); Wed, 19 Jul 2017 02:23:51 -0400 Date: Wed, 19 Jul 2017 08:22:20 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Rob Herring Cc: arm@kernel.org, Andrew Lunn , Heiko Stuebner , Tony Lindgren , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Magnus Damm , Russell King , Krzysztof Kozlowski , Javier Martinez Canillas , Kukjin Kim , Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Simon Horman , Gregory Clement , linux-omap@vger.kernel.org, Sascha Hauer , linux-arm-kernel@lists.infradead.org, Paul Walmsley , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, =?iso-8859-1?Q?Beno=EEt?= Cousson , Fabio Estevam , Shawn Guo Subject: Re: [PATCH] ARM: Convert to using %pOF instead of full_name Message-ID: <20170719062220.wefnkqhd7javbcee@pengutronix.de> References: <20170718214339.7774-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170718214339.7774-1-robh@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:5054:ff:fe2a:3aa X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing Oh nice. If the commit adding %pOF is already set in stone, i'd suggest to mention the commit id here in the commit log. > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Russell King > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Javier Martinez Canillas > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Fabio Estevam > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Sebastian Hesselbarth > Cc: Tony Lindgren > Cc: "Benoît Cousson" > Cc: Paul Walmsley > Cc: Heiko Stuebner > Cc: Simon Horman > Cc: Magnus Damm > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > --- > arch/arm/kernel/cpuidle.c | 4 ++-- > arch/arm/kernel/devtree.c | 6 +++--- > arch/arm/kernel/topology.c | 4 ++-- > arch/arm/mach-exynos/suspend.c | 8 ++++---- > arch/arm/mach-imx/gpc.c | 4 ++-- > arch/arm/mach-mvebu/kirkwood.c | 4 ++-- > arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- > arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- > arch/arm/mach-rockchip/platsmp.c | 4 ++-- > arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- > 10 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c > index a3308ad1a024..fda5579123a8 100644 > --- a/arch/arm/kernel/cpuidle.c > +++ b/arch/arm/kernel/cpuidle.c > @@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node *dn, int cpu) > > ops = arm_cpuidle_get_ops(enable_method); > if (!ops) { > - pr_warn("%s: unsupported enable-method property: %s\n", > - dn->full_name, enable_method); > + pr_warn("%pOF: unsupported enable-method property: %s\n", > + dn, enable_method); > return -EOPNOTSUPP; > } > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > index f676febbb270..28174c9a94ac 100644 > --- a/arch/arm/kernel/devtree.c > +++ b/arch/arm/kernel/devtree.c > @@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void) > if (of_node_cmp(cpu->type, "cpu")) > continue; > > - pr_debug(" * %s...\n", cpu->full_name); > + pr_debug(" * %pOF...\n", cpu); > /* > * A device tree containing CPU nodes with missing "reg" > * properties is considered invalid to build the > @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void) > */ > cell = of_get_property(cpu, "reg", &prop_bytes); > if (!cell || prop_bytes < sizeof(*cell)) { > - pr_debug(" * %s missing reg property\n", > - cpu->full_name); > + pr_debug(" * %pOF missing reg property\n", > + cpu); You could join lines here and in the next hunk. And there are two more further down. > of_node_put(cpu); > return; > } > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index bf949a763dbe..e596c5b8f931 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) > > rate = of_get_property(cn, "clock-frequency", &len); > if (!rate || len != 4) { > - pr_err("%s missing clock-frequency property\n", > - cn->full_name); > + pr_err("%pOF missing clock-frequency property\n", > + cn); > continue; > } > Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |