linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vijay.ac.kumar@oracle.com
Cc: sparclinux@vger.kernel.org, rob.gardner@oracle.com,
	anthony.yznaga@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu
Date: Thu, 20 Jul 2017 12:58:50 -0700 (PDT)	[thread overview]
Message-ID: <20170720.125850.1894569815191415786.davem@davemloft.net> (raw)
In-Reply-To: <1499545424-415240-3-git-send-email-vijay.ac.kumar@oracle.com>

From: Vijay Kumar <vijay.ac.kumar@oracle.com>
Date: Sat,  8 Jul 2017 14:23:44 -0600

> diff --git a/arch/sparc/kernel/hvapi.c b/arch/sparc/kernel/hvapi.c
> index 2677312..0b070d5 100644
> --- a/arch/sparc/kernel/hvapi.c
> +++ b/arch/sparc/kernel/hvapi.c
> @@ -189,7 +189,7 @@ void __init sun4v_hvapi_init(void)
>  
>  	group = HV_GRP_CORE;
>  	major = 1;
> -	minor = 1;
> +	minor = 6; /* CPU POKE */
>  	if (sun4v_hvapi_register(group, major, &minor))
>  		goto bad;

That CPU POKE comment will not stand the test of time, please remove it.

> +	/* Use cpu poke to resume idle cpu if supported*/

Please put a space at the end of the comment and before the "*/"

> +		/*cpu poke is registered. */

Please put a space at the beginning of the comment.

And you should decide which way you want to consistently write.
Either capitalize the first word and finish the sentence with
a '.', or don't.  Do it the same way each time.

Thanks.

  reply	other threads:[~2017-07-20 19:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08 20:23 [PATCH 0/2] sparc64: Use low latency path to resume idle cpu Vijay Kumar
2017-07-08 20:23 ` [PATCH 1/2] sparc64: Add a new hypercall CPU_POKE Vijay Kumar
2017-07-08 20:23 ` [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu Vijay Kumar
2017-07-20 19:58   ` David Miller [this message]
2017-07-21  2:47     ` Vijay Kumar
2017-07-20 19:57 ` [PATCH 0/2] sparc64: Use low latency path " David Miller
2017-07-21  2:44   ` Vijay Kumar
2017-07-21  2:55     ` David Miller
2017-07-21  3:36       ` Vijay Kumar
2017-07-21  3:45         ` David Miller
2017-07-21  4:11           ` Vijay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720.125850.1894569815191415786.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anthony.yznaga@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.gardner@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=vijay.ac.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).