From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936478AbdGTPNe (ORCPT ); Thu, 20 Jul 2017 11:13:34 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:38754 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935486AbdGTPNc (ORCPT ); Thu, 20 Jul 2017 11:13:32 -0400 Date: Thu, 20 Jul 2017 18:13:28 +0300 From: Sakari Ailus To: Todor Tomov Cc: mchehab@kernel.org, hans.verkuil@cisco.com, javier@osg.samsung.com, s.nawrocki@samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 15/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface Message-ID: <20170720151328.7ph3wlqszdiba72a@valkosipuli.retiisi.org.uk> References: <1500287629-23703-1-git-send-email-todor.tomov@linaro.org> <1500287629-23703-16-git-send-email-todor.tomov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500287629-23703-16-git-send-email-todor.tomov@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 01:33:41PM +0300, Todor Tomov wrote: > Update Qualcomm Camera Subsystem driver document for the PIX interface > and format conversion support. > > Signed-off-by: Todor Tomov > --- > Documentation/media/v4l-drivers/qcom_camss.rst | 41 +++++++++++++++++++------- > 1 file changed, 31 insertions(+), 10 deletions(-) > > diff --git a/Documentation/media/v4l-drivers/qcom_camss.rst b/Documentation/media/v4l-drivers/qcom_camss.rst > index 4707ea7..4df5655 100644 > --- a/Documentation/media/v4l-drivers/qcom_camss.rst > +++ b/Documentation/media/v4l-drivers/qcom_camss.rst > @@ -45,12 +45,31 @@ Supported functionality > > The current version of the driver supports: > > -- input from camera sensor via CSIPHY; > -- generation of test input data by the TG in CSID; > -- raw dump of the input data to memory. RDI interface of VFE is supported. > - PIX interface (ISP processing, statistics engines, resize/crop, format > - conversion) is not supported in the current version; > -- concurrent and independent usage of two data inputs - could be camera sensors > +- Input from camera sensor via CSIPHY; > +- Generation of test input data by the TG in CSID; > +- RDI interface of VFE - raw dump of the input data to memory. > + > + Supported formats: > + > + - YUYV/UYVY/YVYU/VYUY (packed YUV 4:2:2); > + - MIPI RAW8 (8bit Bayer RAW); > + - MIPI RAW10 (10bit packed Bayer RAW); > + - MIPI RAW12 (12bit packed Bayer RAW). > + > +- PIX interface of VFE > + > + - Format conversion of the input data. > + > + Supported input formats: > + > + - YUYV/UYVY/YVYU/VYUY (packed YUV 4:2:2). > + > + Supported output formats: > + > + - NV12/NV21 (two plane YUV 4:2:0); > + - NV16/NV61 (two plane YUV 4:2:2). Could you add V4L2 format names to these? > + > +- Concurrent and independent usage of two data inputs - could be camera sensors > and/or TG. > > > @@ -65,15 +84,15 @@ interface, the driver is split into V4L2 sub-devices as follows: > - 2 CSID sub-devices - each CSID is represented by a single sub-device; > - 2 ISPIF sub-devices - ISPIF is represented by a number of sub-devices equal > to the number of CSID sub-devices; > -- 3 VFE sub-devices - VFE is represented by a number of sub-devices equal to > - the number of RDI input interfaces. > +- 4 VFE sub-devices - VFE is represented by a number of sub-devices equal to > + the number of the input interfaces (3 RDI and 1 PIX). > > The considerations to split the driver in this particular way are as follows: > > - representing CSIPHY and CSID modules by a separate sub-device for each module > allows to model the hardware links between these modules; > -- representing VFE by a separate sub-devices for each RDI input interface allows > - to use the three RDI interfaces concurently and independently as this is > +- representing VFE by a separate sub-devices for each input interface allows > + to use the input interfaces concurently and independently as this is > supported by the hardware; > - representing ISPIF by a number of sub-devices equal to the number of CSID > sub-devices allows to create linear media controller pipelines when using two > @@ -99,6 +118,8 @@ nodes) is as follows: > - msm_vfe0_video1 > - msm_vfe0_rdi2 > - msm_vfe0_video2 > +- msm_vfe0_pix > +- msm_vfe0_video3 > > > Implementation > -- > 2.7.4 > -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk