linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
To: ima-devel <linux-ima-devel@lists.sourceforge.net>
Cc: containers <containers@lists.linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-security-module <linux-security-module@vger.kernel.org>,
	Tycho Andersen <tycho@docker.com>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	Yuqiong Sun <sunyuqiong1988@gmail.com>,
	David Safford <david.safford@ge.com>,
	Mehmet Kayaalp <mkayaalp@cs.binghamton.edu>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	Guilherme Magalhaes <guilherme.magalhaes@hpe.com>,
	Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
Subject: [RFC PATCH 5/5] ima: Add ns_mnt, dev, ino fields to IMA audit measurement msgs
Date: Thu, 20 Jul 2017 18:50:33 -0400	[thread overview]
Message-ID: <20170720225033.21298-6-mkayaalp@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170720225033.21298-1-mkayaalp@linux.vnet.ibm.com>

From: Guilherme Magalhaes <guilherme.magalhaes@hpe.com>

Extending audit measurement record with mount namespace id, file inode,
and device name. These fields uniquely identify a pathname considering
different mount namespaces. The file inode on a given device is unique
and these fields are required to identify a namespace id since this id
can be released and later reused by a different process.

Signed-off-by: Guilherme Magalhaes <guilherme.magalhaes@hpe.com>

Changelog:
* Change the field name from "mnt_ns" to "ns_mnt"

Signed-off-by: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
---
 security/integrity/ima/ima_api.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
index 4a77072..084b126 100644
--- a/security/integrity/ima/ima_api.c
+++ b/security/integrity/ima/ima_api.c
@@ -18,6 +18,7 @@
 #include <linux/fs.h>
 #include <linux/xattr.h>
 #include <linux/evm.h>
+#include <linux/proc_ns.h>
 
 #include "ima.h"
 
@@ -296,6 +297,7 @@ void ima_audit_measurement(struct integrity_iint_cache *iint,
 	char algo_hash[sizeof(hash) + strlen(algo_name) + 2];
 	int i;
 	unsigned long flags = iint_flags(iint, status);
+	struct ns_common *ns;
 
 	if (flags & IMA_AUDITED)
 		return;
@@ -314,6 +316,14 @@ void ima_audit_measurement(struct integrity_iint_cache *iint,
 	audit_log_format(ab, " hash=");
 	snprintf(algo_hash, sizeof(algo_hash), "%s:%s", algo_name, hash);
 	audit_log_untrustedstring(ab, algo_hash);
+	ns = mntns_operations.get(current);
+	if (!IS_ERR_OR_NULL(ns)) {
+		audit_log_format(ab, " ns_mnt=%u", ns->inum);
+		mntns_operations.put(ns);
+	}
+	audit_log_format(ab, " dev=");
+	audit_log_untrustedstring(ab, iint->inode->i_sb->s_id);
+	audit_log_format(ab, " ino=%lu", iint->inode->i_ino);
 
 	audit_log_task_info(ab, current);
 	audit_log_end(ab);
-- 
2.9.4

      parent reply	other threads:[~2017-07-20 22:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 22:50 [RFC PATCH 0/5] ima: namespacing IMA audit messages Mehmet Kayaalp
2017-07-20 22:50 ` [RFC PATCH 1/5] ima: extend clone() with IMA namespace support Mehmet Kayaalp
2017-07-25 17:53   ` Serge E. Hallyn
2017-07-25 18:49     ` James Bottomley
2017-07-25 19:04       ` Serge E. Hallyn
2017-07-25 19:08         ` James Bottomley
2017-07-25 19:48           ` Mimi Zohar
2017-07-25 20:11             ` Stefan Berger
2017-07-25 20:46               ` Serge E. Hallyn
2017-07-25 20:57                 ` Mimi Zohar
2017-07-25 21:08                   ` Serge E. Hallyn
2017-07-25 21:28                     ` Mimi Zohar
2017-07-27 12:51                       ` [Linux-ima-devel] " Magalhaes, Guilherme (Brazil R&D-CL)
2017-07-27 14:39                         ` Mimi Zohar
2017-07-27 17:18                           ` Magalhaes, Guilherme (Brazil R&D-CL)
2017-07-27 17:49                             ` Stefan Berger
2017-07-27 19:39                               ` Magalhaes, Guilherme (Brazil R&D-CL)
2017-07-27 20:51                                 ` Stefan Berger
2017-07-28 14:19                           ` Magalhaes, Guilherme (Brazil R&D-CL)
2017-07-31 11:31                             ` Mimi Zohar
2017-07-25 21:35                 ` Stefan Berger
2018-03-08 14:04                 ` Stefan Berger
2018-03-09  2:59                   ` Serge E. Hallyn
2018-03-09 13:52                     ` Stefan Berger
2018-03-11 22:58                       ` James Morris
2018-03-13 18:02                         ` Stefan Berger
2018-03-13 21:51                           ` James Morris
2017-07-25 20:31             ` James Bottomley
2017-07-25 20:47               ` Mimi Zohar
2018-03-08 13:39   ` Stefan Berger
2018-03-08 20:19     ` Serge E. Hallyn
     [not found]       ` <a6ef5679-6aef-21de-7cdb-48e8af83f874@linux.vnet.ibm.com>
2018-03-08 23:31         ` Serge E. Hallyn
2017-07-20 22:50 ` [RFC PATCH 2/5] ima: Add ns_status for storing namespaced iint data Mehmet Kayaalp
2017-07-25 19:43   ` Serge E. Hallyn
2017-07-25 20:15     ` Mimi Zohar
2017-07-25 20:25       ` Stefan Berger
2017-07-25 20:49       ` Serge E. Hallyn
2017-08-11 15:00   ` Stefan Berger
2017-07-20 22:50 ` [RFC PATCH 3/5] ima: mamespace audit status flags Mehmet Kayaalp
2017-08-01 17:17   ` Tycho Andersen
2017-08-01 17:25     ` Mehmet Kayaalp
2017-08-02 21:48       ` Tycho Andersen
2017-07-20 22:50 ` [RFC PATCH 4/5] ima: differentiate auditing policy rules from "audit" actions Mehmet Kayaalp
2017-07-20 22:50 ` Mehmet Kayaalp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720225033.21298-6-mkayaalp@linux.vnet.ibm.com \
    --to=mkayaalp@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=david.safford@ge.com \
    --cc=guilherme.magalhaes@hpe.com \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mkayaalp@cs.binghamton.edu \
    --cc=serge@hallyn.com \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=sunyuqiong1988@gmail.com \
    --cc=tycho@docker.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).