From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754410AbdGUOlI (ORCPT ); Fri, 21 Jul 2017 10:41:08 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32836 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099AbdGUOjb (ORCPT ); Fri, 21 Jul 2017 10:39:31 -0400 From: Michal Hocko To: Andrew Morton Cc: Mel Gorman , Johannes Weiner , Vlastimil Babka , , LKML , Michal Hocko , Toshi Kani Subject: [PATCH 5/9] mm, memory_hotplug: remove explicit build_all_zonelists from try_online_node Date: Fri, 21 Jul 2017 16:39:11 +0200 Message-Id: <20170721143915.14161-6-mhocko@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170721143915.14161-1-mhocko@kernel.org> References: <20170721143915.14161-1-mhocko@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko try_online_node calls hotadd_new_pgdat which already calls build_all_zonelists. So the additional call is redundant. Even though hotadd_new_pgdat will only initialize zonelists of the new node this is the right thing to do because such a node doesn't have any memory so other zonelists would ignore all the zones from this node anyway. Cc: Toshi Kani Acked-by: Vlastimil Babka Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 639b8af37c45..0d2f6a11075c 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1104,13 +1104,6 @@ int try_online_node(int nid) node_set_online(nid); ret = register_one_node(nid); BUG_ON(ret); - - if (pgdat->node_zonelists->_zonerefs->zone == NULL) { - mutex_lock(&zonelists_mutex); - build_all_zonelists(NULL); - mutex_unlock(&zonelists_mutex); - } - out: mem_hotplug_done(); return ret; -- 2.11.0