From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755481AbdGXG5R (ORCPT ); Mon, 24 Jul 2017 02:57:17 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:10692 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753065AbdGXG5L (ORCPT ); Mon, 24 Jul 2017 02:57:11 -0400 Date: Mon, 24 Jul 2017 14:51:46 +0800 From: Baolin Wang To: , , CC: , , , , , Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation Message-ID: <20170724065146.GA22330@spreadtrum.com> Mail-Followup-To: wsa@the-dreams.de, mark.rutland@arm.com, robh+dt@kernel.org, andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com v6O6tUMV015177 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 五, 7月 14, 2017 at 05:01:10下午 +0800, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum I2C > controller device. > > Signed-off-by: Baolin Wang > Acked-by: Rob Herring > --- > Changes since v3: > - Add Ack from RobH. > > Changes since v2: > - Change compatible strings to be SoC specific. > > Changes since v1: > - No updates. > --- Could you apply this patchset if there are no other comments? It is a long time since the v4 was send out. Thanks. > Documentation/devicetree/bindings/i2c/i2c-sprd.txt | 31 ++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-sprd.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-sprd.txt b/Documentation/devicetree/bindings/i2c/i2c-sprd.txt > new file mode 100644 > index 0000000..60b7cda > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-sprd.txt > @@ -0,0 +1,31 @@ > +I2C for Spreadtrum platforms > + > +Required properties: > +- compatible: Should be "sprd,sc9860-i2c". > +- reg: Specify the physical base address of the controller and length > + of memory mapped region. > +- interrupts: Should contain I2C interrupt. > +- clock-names: Should contain following entries: > + "i2c" for I2C clock, > + "source" for I2C source (parent) clock, > + "enable" for I2C module enable clock. > +- clocks: Should contain a clock specifier for each entry in clock-names. > +- clock-frequency: Constains desired I2C bus clock frequency in Hz. > +- #address-cells: Should be 1 to describe address cells for I2C device address. > +- #size-cells: Should be 0 means no size cell for I2C device address. > + > +Optional properties: > +- Child nodes conforming to I2C bus binding > + > +Examples: > +i2c0: i2c@70500000 { > + compatible = "sprd,sc9860-i2c"; > + reg = <0 0x70500000 0 0x1000>; > + interrupts = ; > + clock-names = "i2c", "source", "enable"; > + clocks = <&clk_i2c3>, <&ext_26m>, <&clk_ap_apb_gates 11>; > + clock-frequency = <400000>; > + #address-cells = <1>; > + #size-cells = <0>; > +}; > + > -- > 1.7.9.5 >