From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Paul Turner <pjt@google.com>
Subject: Re: [PATCH] perf tool sort: Use default sort if evlist is empty
Date: Wed, 26 Jul 2017 17:03:25 -0300 [thread overview]
Message-ID: <20170726200325.GG23846@kernel.org> (raw)
In-Reply-To: <20170721051157.47331-1-davidcc@google.com>
Em Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros escreveu:
> Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused
> by commit d49dadea7862 ("perf tools: Make 'trace' or 'trace_fields' sort
> key default for tracepoint events")
> not taking into account that evlist is empty in pipe-mode.
>
> Before this commit, pipe mode will only show bogus "100.00% N/A" instead
> of correct output as follows:
>
Thanks, tested and applied.
- Arnaldo
prev parent reply other threads:[~2017-07-26 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 5:11 [PATCH] perf tool sort: Use default sort if evlist is empty David Carrillo-Cisneros
2017-07-21 7:44 ` Jiri Olsa
2017-07-21 20:02 ` David Carrillo-Cisneros
2017-07-22 23:09 ` Namhyung Kim
2017-07-24 7:47 ` Jiri Olsa
2017-07-24 10:43 ` David Carrillo-Cisneros
2017-07-26 20:03 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726200325.GG23846@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pjt@google.com \
--cc=sque@chromium.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).