From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbdG0HKk (ORCPT ); Thu, 27 Jul 2017 03:10:40 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:37766 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbdG0HKi (ORCPT ); Thu, 27 Jul 2017 03:10:38 -0400 Date: Thu, 27 Jul 2017 09:10:34 +0200 From: Ingo Molnar To: Borislav Petkov Cc: linux-edac , Steven Rostedt , Tony Luck , Yazen Ghannam , X86 ML , LKML Subject: Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Message-ID: <20170727071034.epbwwmgnbj6dv4sf@gmail.com> References: <20170725154601.27427-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170725154601.27427-1-bp@alien8.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > From: Borislav Petkov > > Hi, > > here's a first stab at adding a tracepoint which dumps the decoded MCE > string to userspace. The main idea is to have the decoding functionality > in the kernel and depending on whether you have userspace consumers > listening or not, to dump the error to the tracepoint or to dmesg. > > In either case, we do the decoding in the kernel and don't need special > userspace. Furthermore, adding new CPU support will have to be done only > in one place. > > First 6 patches are cleanups which are good to have regardless, IMO. > > Any constructive comments and suggestions are appreciated. > > Thanks. > > P.S., Thanks to Rostedt for the input! > > Borislav Petkov (8): > EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() > EDAC, mce_amd: Get rid of most struct cpuinfo_x86 uses > EDAC, mce_amd: Get rid of local var in amd_filter_mce() > seq_buf: Add seq_buf_clear_buf() > seq_buf: Export seq_buf_printf() to modules > EDAC, mce_amd: Convert to seq_buf > EDAC, mce_amd: Add a simple tracepoint dumping a decoded string > EDAC, mce_amd: Issue the decoded info through the TP or printk > > drivers/edac/mce_amd.c | 285 +++++++++++++++++++++++++++--------------------- > drivers/ras/ras.c | 1 + > include/linux/seq_buf.h | 7 ++ > include/ras/ras_event.h | 16 +++ > lib/seq_buf.c | 1 + > 5 files changed, 186 insertions(+), 124 deletions(-) Looks pretty nice to me conceptually. Do you have a couple of examples of real-life events that get logged? It's hard to decode it from the new tracepoint alone. Thanks, Ingo