From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbdG0JxE (ORCPT ); Thu, 27 Jul 2017 05:53:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:33033 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750878AbdG0JxC (ORCPT ); Thu, 27 Jul 2017 05:53:02 -0400 Date: Thu, 27 Jul 2017 11:52:18 +0200 From: Borislav Petkov To: Punit Agrawal Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Message-ID: <20170727095218.GB4611@nazgul.tnic> References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-4-punit.agrawal@arm.com> <20170720111732.GC18515@nazgul.tnic> <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> <20170720135446.GA20641@nazgul.tnic> <87shhrknes.fsf@e105922-lin.cambridge.arm.com> <20170721132731.GA5041@nazgul.tnic> <87zibqi5n2.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zibqi5n2.fsf@e105922-lin.cambridge.arm.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2017 at 10:35:45AM +0100, Punit Agrawal wrote: > ... would you be open to a patch re-working the ghes driver > initialisation to only do the platform driver registration. The the rest > of the initialisation (including the apei_osc_setup and related > messages) can be performed when the first ghes device gets probed. > > Does that sound like a better alternative? If you split it by doing one logical change per patch so that it is obvious what's going on and you don't break existing usage, I don't see why not. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --