From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbdG0Ozk (ORCPT ); Thu, 27 Jul 2017 10:55:40 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:53420 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdG0Ozi (ORCPT ); Thu, 27 Jul 2017 10:55:38 -0400 Date: Thu, 27 Jul 2017 15:55:13 +0100 From: Roman Gushchin To: Michal Hocko CC: Tetsuo Handa , , , , , Subject: Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Message-ID: <20170727145513.GA1185@castle.DHCP.thefacebook.com> References: <20170727090357.3205-1-mhocko@kernel.org> <20170727090357.3205-3-mhocko@kernel.org> <201707272301.EII82876.tOOJOFLMHFQSFV@I-love.SAKURA.ne.jp> <20170727144544.GC31031@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170727144544.GC31031@dhcp22.suse.cz> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [2620:10d:c092:200::1:cf6a] X-ClientProxiedBy: AM3PR07CA0117.eurprd07.prod.outlook.com (2603:10a6:207:7::27) To BL2PR15MB1076.namprd15.prod.outlook.com (2603:10b6:201:17::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48274f71-1136-4546-e41f-08d4d4ff8382 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BL2PR15MB1076; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;3:KYAMF3Y9SxpTTPFtoiTCK98X5ZZtbRyZs3W96gyKb6Fdwz/SD+XeZwMEs4Ymjc9uIhH3x5YbeBFy7Lp1tbmUi4eU71ilRzbmTC8wcUvEu8rdQAOdnilXqG5itmulNeAgAm5MUBWsRQTCfzmlYBazEocpSRMeG0GWTmeaFwHrWVAK1pmNyYAKhIDFUm4vMe0bLiN4WN7XQgPAx3POIVHsJyxt4clskPC2uh7Er+qDAr6OmhTSdjBwVq2YFoFJCY6YcAnt1VT1MOgBuWl12xNT1wjwHxM7ShwbKh9d2kQvqaQ6hHCt/vIJX0N+9NHFgp4vAD1b63tCSFQ+8C4+X5LLK2PwbN3ftzBvo32SB70lw6nPbKeIO4P97p0waPhQknCTE/hzt7MEmBpiPAjsaFFX4pId9EABxf67ERYNzaEX02s5x+jKieeOsIfrC1fRPo/KHuSQrikLRMixKdNCBvstOJWi/tIkQdDjyeOY1knrLhM2lyiKjWLsiiTJSIPokx55QuG9yTA467aYWW5NfWFlVQBzGUNIvg9N8eY0c/5nHQGsmLYdJ7xq8hFZAJq5RZd1faJ/NcCpNPkyTt97P/SneUkc7BnwXkyl6tUhQc1IdQ8JXW3Wpo5mFuMwMhdhpA5J/pVWY6oEjoD9ovgF9Iir5JLYiM2rjIjrNqI+vTtXagzc2FIr8++qXVZT1KdWL2uta9rkkkXjWnWTxd9T6V9iqpuVmas0Kl/pCwoajEjcSCw= X-MS-TrafficTypeDiagnostic: BL2PR15MB1076: X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;25:IUV/X054PklGfp9v9r9wsPfbsAYy27ya0bnzPSP7C0wRB/1KEspyODPLmlHyS4TZ7w8a1ez8aAiKGcf12GBg1oKgJEHxjD6Z5jEV6CokqzfKCJvQNPRlJLu1qIvwHb/5sD70H6AIAOeoXGE/dfRBzPpOltguJ978q08i6nsYSvHGrAdz7tAyxzsmBUYamvtQux0IqyQyHqkscO4ADIAtkZ1o9UJ/HAtl5zt8IMNGg5RdnWbNfKZTxa0cHTOB8jHcgk+7XCL+dPCtO6qHUUQYeDmE7PV6RA73xO881385zV3tNmYL2csRrRgzAOVAt7YCrEfs8UOzFJzDeRzYnU8PBqUhHlemeNGZTWUsQLQZFDsJDQUUQQL8O4FU9Ug+5l9/a858142sGyFDyP9Foi+xohUmvkKD0eowxoU5cCFT9okIbuiz5RCzVeVCsemXtHMnOIEfDJn1FeSTBi48HsabMXm+OLhXlHkiyLtjU4Z1R8c33EWVMt7jhu1Vgqt+MVN9uuPvL5KxYP4Rok6CHndqTMYks2UXbV20TN5e7DogToX6rPJLMSLJZn9PzGcsNfd3c5Uumh+VTZwwW9KVTdbgaqDsNYyKobb781ckXxjK5huRpFvxEZFaxmgMdI6VDP8AXHg5FiVfa0NIEX3KvMAFSuOII/Dxz8UVBvX7BbkISVj++RRWGRhbpVUH5jImjDfR5bWKtZteg7ymAEnH154dzSlG2sSip2/a9TCcMcFPj5BNVRv7vqdq7Uleo39wRwRdsbMoXGETEQvvQrYrI70TK6L+FQE+gKIZXmK0IUe6mf1PYCssQ5dXEBbVRyBMT2xLKpEZacCLthvU0Qsare+Jmgo+BOhtN0kpTDFZ3+oROB4enlpp+eNa8uGRzKo3dZ3QU8du6ld+qPURu168MYV4DasnC3y0VJznxCdeEJVSkm4= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;31:MLAXdw5V9EqyTYW7EC+8NE9IGnf+IUL27eOto9PQE0kZc310RudMWmfAAQdsZpJ1cE8BC3GxzZQVd6IJKmCAux3x4STCIlg8ugKf8scKRY1vCVBh3Ik27hhGw3nZHZ8Ws+r5WwgiSfLOAT9ME8KQPG99jRzL2YS8T6/V6q/Que2kTMtGHBKGVI6OhA6sLCSMbjaUNs2JNPk+SBKUyHp3l8w05K69ERs8FMnzektVj6plI/vTPY5MicAVyx2++Or1epJW3ZEXcmkakr+J9QbTQImb180u3DehH6pnTDFw9HXApOGCs4c8b0o6OwqkwblwnmJ02NmY20lW8kGIZGAsxclTiweT1qDWdXIF6CgMPOTgQe2UOSuS7Rq9To5DR1Hec5WrsANIQCRWQ608XJAQNpyezEz68jWHDQ/cmQX4bQHu7BJOEdkuRQvQnIB+e1PXiC7xBW+XCzaNzttANpUl5ltuPqYGQathBErn18qZ3WVw7ob5As+3h8RPqKu+i4cCgvuPb4FbdTAClIQCrr4cnV5il3ACQcM6SzIXzqfHeXa+/kDklJktG2LKG0gYzMKsRZwC+2cAGnyQ/kF6kcEsNDOa0yyNYnElG7LU+Awm/rx5KPjuro4TmnWbyFjZMtMuSeo7uoFnovG9r/5Q06D7tEU9IvdSXn9Ry7d6dzUOa2c+uDcrLHslp7pcwNvtZu6y/wED8xh7veAyWtJ+pwhVWg== X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;20:cyH0QPGwo5ZWZFtB2vbnfsYDvxYbnL/9lQLOEykHp2YPYBKZqSUWsIWhPTc6GbA1Ehp9rbNxZQzOjxllstkhj8oMTZkk1D8QzIqJhRAjq+kXIvBMaR281/AxjMaRzUkqV6PsrofzM2xlqq2bRvjLgdfdX6Vl0vhSYt30fd8DdmQEljF778A4e5dHVJeLwFtFlhkWLy1eO88MwbGR7u8LxFM62MDIijPu7+7XmtrVQbgNwnZfw4sIuJcqLYY4qJ57e2XKfCaMBCTzqoyc5KCfqhTDUvFWNUMPr6hCcK0cWm7ZYKfwaL5O7yuSTwC9alq44vDzRuuxoNwj2DME1KKOkBA/dqXbcEGafgvLR7U08iwF0pGtm8rL2HuXjX0oiCiM3+ECkOtewdWO4Ao9wNcWvfo4/GUfJ5PF6n9I6psEqd6ETw3XN0wcqnM+IaUhISMupQJv5YxTXU7VtRgCs6M0MY5UStdQ4GApbzunJoisAnTBB/mKTbhXBLyD5IsKXw/g X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(42068640409301); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(20161123562025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BL2PR15MB1076;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BL2PR15MB1076; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1076;4:6/ZpUZutI3g24AxsVfBWan1HgRI9cgsm1LmK3YLzKZ?= =?us-ascii?Q?VMuidvEKkYAegqLNmY9+HKXM4gXwSFTt56jXlSMYnN5ATn2tmjQqe9n7dzsr?= =?us-ascii?Q?6OPwexJQV2zU0KQTfP5L7sCV3/f3TeI1QWWAPiu3+3daVIKNzUUy4WFQqZtC?= =?us-ascii?Q?YBuH/C/ruT7VV/36CwJYWjE8nPQ0PbUJhN0oOHTPV6y7cx2k/6Zo1gz9dwy0?= =?us-ascii?Q?deDxx6FhmOVfSTE6h6gAFwaoo+ev8yEEdhq7XYWm7i9SDgMrnwvb5IgB3qZR?= =?us-ascii?Q?d7EgujjzaTsEOpo2MIIAoAEe4jirmC2QZwiHAHZJp/9a40MuTbDYyj9FTkab?= =?us-ascii?Q?LqgWDAfOmvy4jquPQgbM1I2ROgE6eMOuX0Bnja+OQ4Z8xCh2a5ravYUbSDPN?= =?us-ascii?Q?tdPlZ6wuAc2LEJGz7jQk9sss94qUHjYmOjKk2Y6lkdWOjTInyeEM7vpUpOl/?= =?us-ascii?Q?NRNQcniQ/7/Fs/FPt+sxBtfcAp6Uwa2PbudxJdzMJs1MG1CogB8z89ZHfbTJ?= =?us-ascii?Q?CZXgLdusIYM7b68KIMy1tp6XiNhD4FRKg1Y0Ydan3EyVX+y8Vqf3y9Bk2cdh?= =?us-ascii?Q?ye4NO8dV7AmztsX0ZBFXx2xbnWpmxdgmcbUOBFUdDawCD0lkd8RPlXnn9cj3?= =?us-ascii?Q?UUkbIcXt6L5IzLW8u3Mzb1KQBDSXRUZGZ2Ir+TSuhDz7bQcY+nJtPcBg9W6/?= =?us-ascii?Q?oI4FWWEKm5icGH/IrZzsy6lIDhkvOXrAvJ6DVj8rUY4FK4tEzi64xGZY3Y/h?= =?us-ascii?Q?BFxr/JHwUpK0quj04t7NTD9XlgCsZbgJfqEYs6iCNWoTomQVYgHaehEotMNy?= =?us-ascii?Q?P0ATKIoRXS4fKkTOBKq3fg/rWobphIqCa489xIZLDN4zwq1lcxRgZkeN331R?= =?us-ascii?Q?kCeFpNE+7X68+32G0+qY41tv0bFA9jx/MToXg2GB48+Si2dDxsxZ9hifJhTH?= =?us-ascii?Q?R01dT5nt54IaU50SSuft5jCJ6EKgiNtJFTwvvVktoY2+0Qwr/pnaplDm7/Gi?= =?us-ascii?Q?W8PbSdzEXNqXuNKylh9HA0DuTcG7X1MAmJR/p7TROKaDAX91fErx8i714idt?= =?us-ascii?Q?AAw07+dAeqxguNhPm1Svl6m2x7NM7Ptl6r3DswgR3mvrGuVkqy4W3Kg7U0KL?= =?us-ascii?Q?hDNMJhUOQJkfMf1kgQKm++4Iln3vbbXcMCsH8LyBuIXzJUy2AQMTZNERHOws?= =?us-ascii?Q?E45z7U0LH3stN83SwbrTh5CcfM1qkvX+PhRTw7cHtDKCYydiwLxXblvg=3D?= =?us-ascii?Q?=3D?= X-Forefront-PRVS: 03818C953D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(7370300001)(6009001)(39410400002)(39840400002)(39850400002)(39400400002)(39450400003)(377424004)(199003)(189002)(24454002)(229853002)(7350300001)(1076002)(8676002)(6506006)(189998001)(7736002)(68736007)(305945005)(9686003)(53936002)(81166006)(4326008)(83506001)(86362001)(5660300001)(33656002)(25786009)(81156014)(6666003)(4001350100001)(6116002)(6306002)(101416001)(42186005)(55016002)(76176999)(50986999)(54356999)(478600001)(6246003)(2906002)(23726003)(106356001)(105586002)(966005)(97736004)(6916009)(47776003)(93886004)(38730400002)(50466002)(2950100002)(110136004)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB1076;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1076;23:aD90Pe3cadGGbvUS/0nw3NrPnQe9Bnn/dOfcXkdYJ?= =?us-ascii?Q?PMVUWzVpKx9AKGBsytX4BicGQ6uGb1Jjvk7/ZV5SArDiDEhktDVBaJw6YMj5?= =?us-ascii?Q?1THlSscgT+5MXVpItVHdjvrrXk+obIflHqHn8YSCm8stsMQNG/yTQN4eSm8O?= =?us-ascii?Q?g5CcGIHJNHi2e/8pDcmtZIHLSb4qc9bn8ec/3j7xYD52paNKDagf0HbHSJGw?= =?us-ascii?Q?oXYpzcdc9FC50af0p/aMp59aWE6YOqTQCQwLmxAB4wplsf+tyrBLlPjZleBn?= =?us-ascii?Q?ElRxHMeVv0xyUeocaRwPLo8A8iBxo7084x3Hs8zUJukiUiPZ5yvPUtVuMuxW?= =?us-ascii?Q?OIwg+JAj/lRZmUnDoOi1jOyfs3XbUb9JQNWjH/w6kN4GF5z4OYOX8waC1z7K?= =?us-ascii?Q?mSWKe4cCfol2mWfgD9w0LTlKJ8abGAmNj9U+FX7mY25mGezphOHh9M+ZGZ8Y?= =?us-ascii?Q?RcMjnX46hpwjPOzBst6tEDCNFyWuqlc0CPGa1UNaHXy/7FM8sUxxjBtjckpb?= =?us-ascii?Q?/6WueeNcbo7NThYL41H7DfqZsMKuONmfjMHb3qsbcHlK3Jymt7UGdrf7fMJb?= =?us-ascii?Q?SIXu6T2npQN5+Gzsf6WoaSYwUv3p0jOT2ESMNYZdXdWZFxjCO0s64RUOrNJ4?= =?us-ascii?Q?sJhrwaoEwrsILwE+3ILlLrUYxRFzpIBMWb3ZNNh1JGMirfhSB2rAYnIcydXn?= =?us-ascii?Q?fnOhrP6qzgBqe+4VKE/+k4sF0h4/ARhElFivJKWBHvxcmm3XSABqg3NcRXjS?= =?us-ascii?Q?XNNtL82mR5I6XS65/EfY8itqkp3WTarh43vRGtpLb9jYJz5te0SxNSXcVJZr?= =?us-ascii?Q?Z/b091YF+OW1wx8cesCRn63sxThJ5iSwTFGK3GVARWbMkBTngLUhop0vxX05?= =?us-ascii?Q?DzHtz4lHdpaIX6PJicmrq2jIcMN4JXJwrV3yf00KTvohYdrcNG7cMI8mbf3K?= =?us-ascii?Q?tPBjEu8Cp7tEEJckgBer/NqTU/6vnbIW9brmf6jnmkXYxBvNQ8Ujp/xTwflX?= =?us-ascii?Q?HFlaeMDJgecHFlQJP/JYoI8/UV+VTJpLDrCxfEY0jcq8R+PhtS/ZxNAslGnP?= =?us-ascii?Q?MwAdWiKw9MLaIC4ZlLyyhJCBMnXO/Kj612KO4JSW4RuCzbe08Sy45XleJjA4?= =?us-ascii?Q?2stEPNT5SAB+JrSyXtL/AZa2HhcTPzeY0GhOZDIL5D0QOE/nqWQfQ9d5fnMx?= =?us-ascii?Q?Xkp60viBETS9WjcccHFgpBrjd45lGFbnNqeZj4jfnSNX58NEL7iLGx4ojYmr?= =?us-ascii?Q?880Mm6N0VYKYkVXckhklnhUH27ujmmJN3RsmbiP9etxf7z+RAjujeyKHQ1a3?= =?us-ascii?Q?fa2yLnXx9nr+Kfk74MXoTQRq7JUYZy36mouoY1V9hJ9cqUTZl3zn6/mFDUDD?= =?us-ascii?Q?e8P1CwrhmvJ9lXnSZ8eyOY01AZWrbtGA8CcOXwN1ia5ZCQ2/OaXA9Q/SM40t?= =?us-ascii?Q?7whq6d1LQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1076;6:mzzQZyd+mBH7TGZpWLxqnIz5HhRJ150RK/6Ve/cuH4?= =?us-ascii?Q?fbJRsk7gFmGwae9nvF7IfN8WPlcHzAJH679S1mywaKxMQiuPZOO5oQV5yv+Y?= =?us-ascii?Q?IWreOJhYYC28tyvWJdA71TlW0JkvcB1sZix+BIP3OHjvUA1JY+bw9kbxiZT6?= =?us-ascii?Q?dawopwQczV2+FpUguI4S7NSicZdsQIV8HMVsPrLYwgb5qO8GGenQ+fU/nP29?= =?us-ascii?Q?ATqUBden/r3TxPn7pC1unWqXyyzzbGzM2lSa0VwztjqVYaLwMaKzZZftNWQN?= =?us-ascii?Q?GaQp883GCp9IMj7ajubd7nxcMg8AHGOk08SumfuqzyhmjxIAbEeVciWF2PBx?= =?us-ascii?Q?668Nabt19F9OkmGI8DdHwbf3709ko5IGxHEXdwQa6YiDqnROOvasUShRbiXp?= =?us-ascii?Q?PRRsebFNXoE0TuuYOcpk3+2B1cQ60fh1LdaV4E7l59UJ7iiw3YlMJFvtrxxM?= =?us-ascii?Q?IoWQu4L+uXr+zlTHt0IojIuJs9KaZUO2jnvGPY/ltxgtlYDTQ531asfnHZaS?= =?us-ascii?Q?ZXf2zGkWqnvzEcB+I6nKs+TqMXFza2y0vFjdFVL70BOY64jQhE8o0QOH/UlA?= =?us-ascii?Q?i3ACPFyfVtw1RIbd5mjSZp/xlRru581Vie9kmJ0FGkkXXbE7CjFizd9z+L7D?= =?us-ascii?Q?SifiMaQWJRDay0Xvt5oUfSQVulYS3W382wEf6Z5YYfN3DrVQLRjZehomOA5d?= =?us-ascii?Q?YIjLliuaYo27H/Km1Z2tCVm7jqty9vl9hR43O2L1ciPRvX2QEKsffM+FUwdq?= =?us-ascii?Q?LFrFp92QpU9cmtm2FxYsMnDnB/TVaEiiGou0daycBZNyaBsff4JS9gdMAPDH?= =?us-ascii?Q?PMiA/sKKlRn1xXBG3jr+k3/OYOUIXhQXG+ZRKWujZJFWlvGf9ccXv3UTDWbN?= =?us-ascii?Q?CJdrdMZGp2Kz6IyDZ5Abdbs2LVCmly1YzegtJV5CR7gVXZjWUcnLJ1jdf3wb?= =?us-ascii?Q?I+Tn8U8TZ9+D+xnBPEmzSGY0RoC64N1UxZV0CgAos9TAGaCQBrPkXSanE1X3?= =?us-ascii?Q?s=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;5:qN8xKFs621jRmrlfTd1sgb9Xwx9opR3sUv2PpTgbT5/UdqCvwfs9qeKqYPuEsFCBqjr53K6bVhfLyMQ5PFLVqH8C+vMCQmpSpe6Vw8BRaiwPXr8doaMYZfgvKTajAnT7zhBlWgYcfrwFteagOq4+pNMyUXPeFnt/etMw5DYgyHJxxfWM4LDJGFxg5C35NPcAdWuCklKWQIwr43JB4uTCZfWhufZrOaFLP3Xu2n8k6R67YY5VeIbqimdYMd8pHnGyvb4vSENLl6VJceUjQKscPvJSstWeUm84N7vhPxEU8nkcMufmzn3Emme69X0lcHqpVTKEnruVnWZJR9niw8OI0VjmLhX/Z7UCTxS52AwJeavu0U/t165SXkye2Kji1OPQbGYBpJPMl2UgqVBM8nDKm5oRdimkI3K+azw01CGae1KNH2/azl0Ij4Ygo25PFoLRll7DrEsEOs3SBJIxezyaqUfZ2X2O4SZ8GiVGeyjfKJz/ZGTfGbO4qSsR0ufADPfY;24:I6FrWYGMGAzT8mhmzOw2sOb081zJCaa1K4KE1N+NCg1vAaejVUxuCfSxzfH5PgK+B9HccykV6TpQ4dink0DSlVMhUbKZvdXKmHnic+2Wbyg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;7:Gs0O8tbhMOXsUs+E5dwgy2OhEN73Oum7tXHoqvCqNFn+wPIMLfZ4pzwRIYN+0mcOg/+zSM34/AZVmfcpcT6YYWH2Cyn+CcpnZ5ic7yFPPlGsYZXY5trjn2bnSthREhaKWwOlAoqAO71yMQbAguKVduPXFGlfvArckedwR1reXMrxHyBoi97uNna9ipB3Fnq4RWKWT/dyBOowxVc1PekMxqWWW/kHhbNJUNbJ+4cF3NbCLflkQqLL2N2H4yqVexDpnae6yDn6xTkA5KKRY93KktTHSliz/83GLQJsibBa5+CHWrnSjZepVOiAFEYq4jqP7ysczh6dJnoCiZMUwClIpUzVhnd3mmuNqiAdNt2KadjrY8lVGV1LtO4JnUjHP/7nDs+S2dJqKFzYPxqbTRiivGtEwr0+b97HN01jl8TLtsPNmzp7/q5+XdOOfeRwasMJjcSzEnP5M+FLNfxFO9L2zicugQDN26edadEd6YE2nAVdutohiB31cyTsUigorrFkNfzMvMW65ri/Tpsfsz5lElqhZprsWijY1RpxL48tcqAk46662k4lWWhE2oYKNoNa03fqr9JDP8iDqWvwh8pdRzBxZPO/t7HDczQ+8rSyk0BMtzPzKHFXqlVaNMCsruWbdwMArPiFZg+tP9RVhql4JYS8YXtKK5Gt3Jtyr3jpSS9sOcRaEHaLNCzGpJRnvHFEWN0FwalIoRE+WvkgPo6ucf2LQmhcSvg/hpqSJvRa14eCWr5M0NJ0EdH1BtygApufruBNYF24c7CX/etMgJAZqzE6Oe26ZXdg5P3AoyF3skM= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;20:A9FUD5luRmCTJrZjUHH1COzuv22a5IdPRRncBJw8qYjYDzOBHRS9avlXVWSPaI3VVTMiEou58+Br+6an4/OuJCy69gCnI30rDxM4V//WexNGadIHQcegxdp5Xua+2o7yR9DLpdgnNMHI8/TSz1e+TyYHmHTd8Y7XoH7lbvPVAok= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2017 14:55:24.2818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB1076 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-27_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2017 at 04:45:44PM +0200, Michal Hocko wrote: > On Thu 27-07-17 23:01:05, Tetsuo Handa wrote: > > Michal Hocko wrote: > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index 544d47e5cbbd..86a48affb938 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -1896,7 +1896,7 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, > > > * bypass the last charges so that they can exit quickly and > > > * free their memory. > > > */ > > > - if (unlikely(test_thread_flag(TIF_MEMDIE) || > > > + if (unlikely(tsk_is_oom_victim(current) || > > > fatal_signal_pending(current) || > > > current->flags & PF_EXITING)) > > > goto force; > > > > Did we check http://lkml.kernel.org/r/20160909140508.GO4844@dhcp22.suse.cz ? > > OK, so your concern was > > > Does this test_thread_flag(TIF_MEMDIE) (or tsk_is_oom_victim(current)) make sense? > > > > If current thread is OOM-killed, SIGKILL must be pending before arriving at > > do_exit() and PF_EXITING must be set after arriving at do_exit(). > > > But I can't find locations which do memory allocation between clearing > > SIGKILL and setting PF_EXITING. > > I can't find them either and maybe there are none. But why do we care > in this particular patch which merely replaces TIF_MEMDIE check by > tsk_is_oom_victim? The code will surely not become less valid. If > you believe this check is redundant then send a patch with the clear > justification. But I would say, at least from the robustness point of > view I would just keep it there. We do not really have any control on > what happens between clearing signals and setting PF_EXITING. I agree, this check is probably redundant, but it really makes no difference, let's keep it bullet-proof. If we care about performance here, we can rearrange the checks: if (unlikely(fatal_signal_pending(current) || current->flags & PF_EXITING) || tsk_is_oom_victim(current)) goto force; Roman