From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbdG0OBN (ORCPT ); Thu, 27 Jul 2017 10:01:13 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:43411 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbdG0OBL (ORCPT ); Thu, 27 Jul 2017 10:01:11 -0400 To: mhocko@kernel.org, akpm@linux-foundation.org Cc: rientjes@google.com, hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com Subject: Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim From: Tetsuo Handa References: <20170727090357.3205-1-mhocko@kernel.org> <20170727090357.3205-3-mhocko@kernel.org> In-Reply-To: <20170727090357.3205-3-mhocko@kernel.org> Message-Id: <201707272301.EII82876.tOOJOFLMHFQSFV@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Thu, 27 Jul 2017 23:01:05 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko wrote: > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 544d47e5cbbd..86a48affb938 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1896,7 +1896,7 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, > * bypass the last charges so that they can exit quickly and > * free their memory. > */ > - if (unlikely(test_thread_flag(TIF_MEMDIE) || > + if (unlikely(tsk_is_oom_victim(current) || > fatal_signal_pending(current) || > current->flags & PF_EXITING)) > goto force; Did we check http://lkml.kernel.org/r/20160909140508.GO4844@dhcp22.suse.cz ? > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index c9f3569a76c7..65cc2f9aaa05 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -483,7 +483,7 @@ static bool __oom_reap_task_mm(struct task_struct *tsk, struct mm_struct *mm) > * [...] > * out_of_memory > * select_bad_process > - * # no TIF_MEMDIE task selects new victim > + * # no TIF_MEMDIE, selects new victim > * unmap_page_range # frees some memory > */ > mutex_lock(&oom_lock); This comment is wrong. No MMF_OOM_SKIP mm selects new victim.