From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbdG1CbE (ORCPT ); Thu, 27 Jul 2017 22:31:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbdG1CbD (ORCPT ); Thu, 27 Jul 2017 22:31:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5E23613170B Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com Date: Fri, 28 Jul 2017 10:31:00 +0800 From: Baoquan He To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 01/13] iommu/amd: Detect pre enabled translation Message-ID: <20170728023100.GF24304@x1> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-2-git-send-email-bhe@redhat.com> <20170727150445.GJ3610@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727150445.GJ3610@suse.de> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 28 Jul 2017 02:31:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/17 at 05:04pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:58:59PM +0800, Baoquan He wrote: > > diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h > > index 294a409e283b..d15966b62b33 100644 > > --- a/drivers/iommu/amd_iommu_types.h > > +++ b/drivers/iommu/amd_iommu_types.h > > @@ -417,6 +417,7 @@ extern struct kmem_cache *amd_iommu_irq_cache; > > #define APERTURE_PAGE_INDEX(a) (((a) >> 21) & 0x3fULL) > > > > > > + > > Forgot to remove that from the diff? Many thanks for your reviewing and great suggestions, Joerg! Will withdraw this change in this patch. > > > /* > > * This struct is used to pass information about > > * incoming PPR faults around. > > @@ -435,6 +436,8 @@ struct iommu_domain; > > struct irq_domain; > > struct amd_irte_ops; > > > > +#define AMD_IOMMU_FLAG_TRANS_PRE_ENABLED (1 << 0) > > + > > /* > > * This structure contains generic data for IOMMU protection domains > > * independent of their use.