From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbdG1JHF (ORCPT ); Fri, 28 Jul 2017 05:07:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60614 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdG1JHE (ORCPT ); Fri, 28 Jul 2017 05:07:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 215A868FC3 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com Date: Fri, 28 Jul 2017 17:07:01 +0800 From: Baoquan He To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Message-ID: <20170728090701.GN24304@x1> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-12-git-send-email-bhe@redhat.com> <20170727155755.GP3610@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727155755.GP3610@suse.de> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 28 Jul 2017 09:07:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/17 at 05:57pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:09PM +0800, Baoquan He wrote: > > When iommu is pre_enabled in kdump kernel, if a device is set up with > > guest translations (DTE.GV=1), then don't copy GCR3 table root pointer > > but move the device over to an empty guest-cr3 table and handle the > > faults in the PPR log (which answer them with INVALID). After all these > > PPR faults are recoverable for the device and we should not allow the > > device to change old-kernels data when we don't have to. > > Okay, forget my previous comment about disabling IOMMUv2 features while > copying. Its done in this patch. Yeah, as you said. Thanks. >