From: Andrew Lunn <andrew@lunn.ch>
To: John Crispin <john@phrozen.org>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection
Date: Fri, 28 Jul 2017 23:25:55 +0200 [thread overview]
Message-ID: <20170728212555.GB11564@lunn.ch> (raw)
In-Reply-To: <82b46393-6c63-eedf-25e4-2bd2278c0d16@phrozen.org>
> thanks for the feedback. should I add 2 callbacks for each of the 2
> parameters ?
Hi John
A single callback is better. We don't want to have to peek into the
packet twice to determine two values.
Andrew
next prev parent reply other threads:[~2017-07-28 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 8:58 [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file John Crispin
2017-07-21 8:58 ` [PATCH V2 2/4] net-next: dsa: add 802.3 protocol offset to struct dsa_device_ops John Crispin
2017-07-21 8:58 ` [PATCH V2 3/4] net-next: dsa: fix flow dissection John Crispin
2017-07-23 20:26 ` kbuild test robot
2017-07-26 15:10 ` Andrew Lunn
2017-07-28 19:40 ` John Crispin
2017-07-28 21:25 ` Andrew Lunn [this message]
2017-07-21 8:58 ` [PATCH V2 4/4] net-next: tag_mtk: add nh and proto offsets to the ops struct John Crispin
2017-07-21 19:12 ` [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file David Miller
2017-07-26 14:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728212555.GB11564@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).