From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbdGaKHG (ORCPT ); Mon, 31 Jul 2017 06:07:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:45694 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751018AbdGaKHF (ORCPT ); Mon, 31 Jul 2017 06:07:05 -0400 Date: Mon, 31 Jul 2017 12:07:02 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 02/13] iommu/amd: add several helper functions Message-ID: <20170731100702.GJ3431@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-3-git-send-email-bhe@redhat.com> <20170727150612.GK3610@suse.de> <20170731100111.GA29157@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170731100111.GA29157@x1> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baoquan, On Mon, Jul 31, 2017 at 06:01:11PM +0800, Baoquan He wrote: > I found the event log related handling functions all take > xxx_event_buffer names, like: > alloc_event_buffer() > iommu_enable_event_buffer() > free_event_buffer() > > So for consistency, I plan to still use iommu_disable_event_buffer(). > Maybe later we can change them in a clean up patch independently. Yeah, makes sense. Go ahead with it. Joerg