From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdGaQfI (ORCPT ); Mon, 31 Jul 2017 12:35:08 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:33275 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdGaQfG (ORCPT ); Mon, 31 Jul 2017 12:35:06 -0400 Date: Mon, 31 Jul 2017 09:35:03 -0700 From: Matthias Kaehlcke To: Arnd Bergmann Cc: Masahiro Yamada , Doug Anderson , Michal Marek , Linux Kbuild mailing list , "linux-kernel@vger.kernel.org" , Grant Grundler , Greg Hackmann , Michael Davidson , Nick Desaulniers , Alexander Potapenko , Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= Subject: Re: [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning Message-ID: <20170731163503.GF84665@google.com> References: <20170421213931.155210-3-mka@chromium.org> <20170517184529.GG141096@google.com> <20170524000419.GQ141096@google.com> <20170621165832.GB52338@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Wed, Jun 21, 2017 at 07:59:42PM +0200 Arnd Bergmann ha dit: > On Wed, Jun 21, 2017 at 6:58 PM, Matthias Kaehlcke wrote: > > El Wed, Jun 21, 2017 at 12:11:55PM +0200 Arnd Bergmann ha dit: > >> I see that container_of() has been modified in linux-next and no longer adds > >> the 'const' keyword, do we actually still need the patch? > > > > There is still (at least) the case of const arrays passed to > > MODULE_DEVICE_TABLE. > > Does the 'const' have any effect there? As it's just an alias, it > should at least > not impact the placement of the symbol in the object file, right? Maybe we can > just remove that 'const' too. Do you see any other instances? For the record: https://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git/commit/?h=modules-next&id=0bf8bf50eddc7511b52461bae798cbfaa0157a34