From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbdHAJYK (ORCPT ); Tue, 1 Aug 2017 05:24:10 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34542 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdHAJYH (ORCPT ); Tue, 1 Aug 2017 05:24:07 -0400 Date: Tue, 1 Aug 2017 11:24:04 +0200 From: Johan Hovold To: Linus Walleij Cc: Anatolij Gustschin , Lee Jones , Alan Tull , Moritz Fischer , "linux-gpio@vger.kernel.org" , linux-fpga@vger.kernel.org, "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Message-ID: <20170801092404.GA30136@localhost> References: <1499374158-12388-1-git-send-email-agust@denx.de> <1499374158-12388-3-git-send-email-agust@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2017 at 08:49:02AM +0200, Linus Walleij wrote: > On Thu, Jul 6, 2017 at 10:49 PM, Anatolij Gustschin wrote: > > > Add driver for CBUS pins on FT232H. The driver supports setting > > GPIO direction and getting/setting CBUS 0-3 pin value. The CBUS > > pins have to be enabled by configuring I/O mode in the FTDI EEPROM. > > > > Signed-off-by: Anatolij Gustschin > Apart from these small things it looks like a solid and nice driver, > do you plan to merge this into MFD or should I merge it? Since it depends > on the Kconfig symbol I guess I can merge it orthogonally if I am sure > Lee will pick the MFD part. There are some fundamental problems with this series which prevents it from being merged. Please take a look at the discussion following patch 1/3. Thanks, Johan