LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] test_kmod: pending patches for v4.14-rc1
@ 2017-08-02 21:17 Luis R. Rodriguez
  2017-08-02 21:17 ` [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing Luis R. Rodriguez
  2017-08-02 21:17 ` [PATCH 2/2] test_kmod: flip INT checks to be consistent Luis R. Rodriguez
  0 siblings, 2 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2017-08-02 21:17 UTC (permalink / raw)
  To: akpm
  Cc: dmitry.torokhov, keescook, jeyu, rusty, mmarek, pmladek, mbenes,
	jpoimboe, ebiederm, shuah, dan.carpenter, colin.king, dcb314,
	linux-kselftest, linux-kernel, Luis R. Rodriguez

Andrew,

After the fixes for v4.13-final which I just sent these are the rest
of the development patches so far queued up for v4.14 for test_kmod.
Its just two minor changes.

These changes are available on my linux-next kernel.org tree on the
20170801-kmod-for-v4.14 branch [0]. Please let me know if there are
any questions or issues.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170801-kmod-for-v4.14

  Luis

Dan Carpenter (2):
  test_kmod: remove paranoid UINT_MAX check on uint range processing
  test_kmod: flip INT checks to be consistent

 lib/test_kmod.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing
  2017-08-02 21:17 [PATCH 0/2] test_kmod: pending patches for v4.14-rc1 Luis R. Rodriguez
@ 2017-08-02 21:17 ` Luis R. Rodriguez
  2017-08-02 21:17 ` [PATCH 2/2] test_kmod: flip INT checks to be consistent Luis R. Rodriguez
  1 sibling, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2017-08-02 21:17 UTC (permalink / raw)
  To: akpm
  Cc: dmitry.torokhov, keescook, jeyu, rusty, mmarek, pmladek, mbenes,
	jpoimboe, ebiederm, shuah, dan.carpenter, colin.king, dcb314,
	linux-kselftest, linux-kernel, Luis R . Rodriguez

From: Dan Carpenter <dan.carpenter@oracle.com>

The UINT_MAX comparison is not needed because "max" is already an unsigned
int, and we expect developer C code max value input to have a sensible
0 - UINT_MAX range. Note that if it so happens to be UINT_MAX + 1 it
would lead to an issue, but we expect the developer to know this.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ff9148969b92..67fc7b9f41e3 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -924,7 +924,7 @@ static int test_dev_config_update_uint_range(struct kmod_test_device *test_dev,
 	if (ret)
 		return ret;
 
-	if (new < min || new >  max || new > UINT_MAX)
+	if (new < min || new > max)
 		return -EINVAL;
 
 	mutex_lock(&test_dev->config_mutex);
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] test_kmod: flip INT checks to be consistent
  2017-08-02 21:17 [PATCH 0/2] test_kmod: pending patches for v4.14-rc1 Luis R. Rodriguez
  2017-08-02 21:17 ` [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing Luis R. Rodriguez
@ 2017-08-02 21:17 ` Luis R. Rodriguez
  1 sibling, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2017-08-02 21:17 UTC (permalink / raw)
  To: akpm
  Cc: dmitry.torokhov, keescook, jeyu, rusty, mmarek, pmladek, mbenes,
	jpoimboe, ebiederm, shuah, dan.carpenter, colin.king, dcb314,
	linux-kselftest, linux-kernel, Luis R . Rodriguez

From: Dan Carpenter <dan.carpenter@oracle.com>

Most checks will check for min and then max, except the int check.
Flip the checks to be consistent with the other code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 67fc7b9f41e3..fba78d25e825 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev,
 	if (ret)
 		return ret;
 
-	if (new > INT_MAX || new < INT_MIN)
+	if (new < INT_MIN || new > INT_MAX)
 		return -EINVAL;
 
 	mutex_lock(&test_dev->config_mutex);
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 21:17 [PATCH 0/2] test_kmod: pending patches for v4.14-rc1 Luis R. Rodriguez
2017-08-02 21:17 ` [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing Luis R. Rodriguez
2017-08-02 21:17 ` [PATCH 2/2] test_kmod: flip INT checks to be consistent Luis R. Rodriguez

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git