From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbdHCOCv (ORCPT ); Thu, 3 Aug 2017 10:02:51 -0400 Received: from foss.arm.com ([217.140.101.70]:41074 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbdHCOCu (ORCPT ); Thu, 3 Aug 2017 10:02:50 -0400 Date: Thu, 3 Aug 2017 15:02:48 +0100 From: Liviu Dudau To: Cihangir Akturk Cc: Brian Starkey , Mali DP Maintainers , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers Message-ID: <20170803140248.GA7201@e110455-lin.cambridge.arm.com> References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-3-git-send-email-cakturk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1501761585-11757-3-git-send-email-cakturk@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cihangir, On Thu, Aug 03, 2017 at 02:58:17PM +0300, Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() and should not be > used by new code. So convert all users of compatibility functions to use > the new APIs. Thank you for the patch! > > Signed-off-by: Cihangir Akturk Acked-by: Liviu Dudau I will pull the patch and send it to Dave. Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_planes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c > index 600fa7b..cb71360 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -57,7 +57,7 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) > struct malidp_plane *mp = to_malidp_plane(plane); > > if (mp->base.fb) > - drm_framebuffer_unreference(mp->base.fb); > + drm_framebuffer_put(mp->base.fb); > > drm_plane_helper_disable(plane); > drm_plane_cleanup(plane); > -- > 2.7.4 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯