linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: divagar.mohandass@intel.com
Cc: mark.rutland@arm.com, wsa@the-dreams.de,
	devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, rajmohan.mani@intel.com
Subject: Re: [PATCH 1/3] dt-bindings: add "size" property.
Date: Thu, 3 Aug 2017 15:27:34 -0500	[thread overview]
Message-ID: <20170803202734.rqyoiqhqvonvvtca@rob-hp-laptop> (raw)
In-Reply-To: <1501173789-25959-2-git-send-email-divagar.mohandass@intel.com>

On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass@intel.com wrote:
> From: Divagar Mohandass <divagar.mohandass@intel.com>

Please improve the subject. Add size to what?

> 
> This adds "size" as optional property for i2c eeproms.
> 
> "size" should be mentioned in byte and it should refer
> to the eeprom size. This will be read by the driver and
> used to calculating the number of bytes in read/write calls.
> 
> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 5696eb5..1436569 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -32,6 +32,8 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - size: total eeprom size in bytes
> +

This should be implied by the compatible string of the eeprom. Why do 
you need this?

Rob

  reply	other threads:[~2017-08-03 20:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 16:43 [PATCH 0/3] enable new "size" property and runtime pm divagar.mohandass
2017-07-27 16:43 ` [PATCH 1/3] dt-bindings: add "size" property divagar.mohandass
2017-08-03 20:27   ` Rob Herring [this message]
2017-08-07  9:08     ` Mohandass, Divagar
2017-09-04  8:57       ` Wolfram Sang
2017-09-04 10:46         ` Mohandass, Divagar
2017-07-27 16:43 ` [PATCH 2/3] eeprom: at24: add support to fetch device property "size" divagar.mohandass
2017-07-27 16:43 ` [PATCH 3/3] eeprom: at24: enable runtime pm support divagar.mohandass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803202734.rqyoiqhqvonvvtca@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=divagar.mohandass@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rajmohan.mani@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).