From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbdHDJjA (ORCPT ); Fri, 4 Aug 2017 05:39:00 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33901 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdHDJi6 (ORCPT ); Fri, 4 Aug 2017 05:38:58 -0400 Date: Fri, 4 Aug 2017 11:38:50 +0200 From: Daniel Vetter To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Boris Brezillon , dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH v5 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths Message-ID: <20170804093745.dtshsrmjl7jpjvp5@phenom.ffwll.local> Mail-Followup-To: Peter Rosin , linux-kernel@vger.kernel.org, Boris Brezillon , dri-devel@lists.freedesktop.org, Daniel Vetter References: <20170713162538.22788-1-peda@axentia.se> <20170713162538.22788-4-peda@axentia.se> <20170714135423.f4uodzns24p7u675@phenom.ffwll.local> <9fd40518-03bc-0568-b822-512c5f6a479c@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fd40518-03bc-0568-b822-512c5f6a479c@axentia.se> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 04, 2017 at 12:49:29AM +0200, Peter Rosin wrote: > On 2017-07-14 15:54, Daniel Vetter wrote: > > On Thu, Jul 13, 2017 at 06:25:27PM +0200, Peter Rosin wrote: > >> The legacy path implements setcmap in terms of crtc .gamma_set. > >> > >> The atomic path implements setcmap by directly updating the crtc gamma_lut > >> property. > >> > >> This has a couple of benefits: > >> - it makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get > >> completely obsolete. They are now unused and subject for removal. > >> - atomic drivers that support clut modes get fbdev support for those from > >> the drm core. This includes atmel-hlcdc, but perhaps others as well? > >> > >> Signed-off-by: Peter Rosin > > > > Ok, I merged the core parts. I'll wait with the driver stuff for a bit > > more (maybe 1-2 weeks) for more acks. Pls remind me in case I forget to > > pull them in. > > > > Thanks a lot for doing this, great work! > > -Daniel > > I don't see the rest it in drm-misc-next and you asked for it, so ping :-) Done, but the last patch doesn't work anymore due to the new vbox driver. Can you pls respin, with that additional patch added? Thanks a lot. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch