From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
andreas.noever@gmail.com, michael.jamet@intel.com,
yehezkel.bernat@intel.com
Subject: Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge
Date: Mon, 7 Aug 2017 11:06:23 +0300 [thread overview]
Message-ID: <20170807080623.GP2369@lahna.fi.intel.com> (raw)
In-Reply-To: <CAAd53p6uJ_LRtLycay=bQG1TsnWeDcKx_b6ZK650-m91vMHWAg@mail.gmail.com>
On Mon, Aug 07, 2017 at 04:00:06PM +0800, Kai-Heng Feng wrote:
> On Mon, Aug 7, 2017 at 3:51 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > At this point we should find out that the ICM is already running and the
> > function never calls pci2cio_write().
>
> I guess you mean this code section:
>
> /* Check if the ICM firmware is already running */
> val = ioread32(nhi->iobase + REG_FW_STS);
> if (val & REG_FW_STS_ICM_EN)
> return 0;
Yes, that's correct.
prev parent reply other threads:[~2017-08-07 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170807044912.18146-1-kai.heng.feng@canonical.com>
2017-08-07 6:50 ` [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge Kai-Heng Feng
2017-08-07 7:02 ` Mika Westerberg
2017-08-07 7:20 ` Kai-Heng Feng
2017-08-07 7:51 ` Mika Westerberg
2017-08-07 8:00 ` Kai-Heng Feng
2017-08-07 8:06 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807080623.GP2369@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).