From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675AbdHGIuE (ORCPT ); Mon, 7 Aug 2017 04:50:04 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:34076 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752478AbdHGIuC (ORCPT ); Mon, 7 Aug 2017 04:50:02 -0400 Date: Mon, 7 Aug 2017 10:49:56 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Linux PM , LKML , Linux ACPI , Thomas Gleixner , Srinivas Pandruvada , Jacob Pan , Len Brown , Daniel Lezcano Subject: Re: [PATCH 1/4] PM / s2idle: Rename PM_SUSPEND_FREEZE to PM_SUSPEND_S2IDLE Message-ID: <20170807084956.4kxkb2y7yxxi4ivw@hirez.programming.kicks-ass.net> References: <1912685.WjJGzNPQ5e@aspire.rjw.lan> <3267088.f3JVtvJoiF@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3267088.f3JVtvJoiF@aspire.rjw.lan> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2017 at 02:56:43PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > To make it clear that the symbol in question refers to > suspend-to-idle, rename it from PM_SUSPEND_FREEZE to > PM_SUSPEND_S2IDLE. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/acpi/sleep.c | 2 - > drivers/regulator/of_regulator.c | 2 - > include/linux/suspend.h | 4 +-- > kernel/power/suspend.c | 44 +++++++++++++++++++-------------------- > kernel/power/suspend_test.c | 4 +-- > 5 files changed, 28 insertions(+), 28 deletions(-) > > Index: linux-pm/include/linux/suspend.h > =================================================================== > --- linux-pm.orig/include/linux/suspend.h > +++ linux-pm/include/linux/suspend.h > @@ -33,10 +33,10 @@ static inline void pm_restore_console(vo > typedef int __bitwise suspend_state_t; > > #define PM_SUSPEND_ON ((__force suspend_state_t) 0) > -#define PM_SUSPEND_FREEZE ((__force suspend_state_t) 1) > +#define PM_SUSPEND_S2IDLE ((__force suspend_state_t) 1) > #define PM_SUSPEND_STANDBY ((__force suspend_state_t) 2) > #define PM_SUSPEND_MEM ((__force suspend_state_t) 3) I feel something like PM_SUSPEND_IDLE is more consistent with the existing PM_SUSPEND_MEM. Also the proposed PM_SUSPEND_S2IDLE has 'SUSPEND' in it twice, so at the very least it should be PM_SUSPEND_2IDLE :-) > -#define PM_SUSPEND_MIN PM_SUSPEND_FREEZE > +#define PM_SUSPEND_MIN PM_SUSPEND_S2IDLE > #define PM_SUSPEND_MAX ((__force suspend_state_t) 4)