linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Chenbo Feng <fengc@google.com>,
	Alison Chaiken <alison@she-devel.com>,
	Juri Lelli <jlelli@google.com>,
	Joel Fernandes <joelaf@google.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org (open list:BPF (Safe dynamic programs and
	tools))
Subject: [PATCH RFC 2/5] samples/bpf: Enable cross compiler support
Date: Mon,  7 Aug 2017 06:03:03 -0700	[thread overview]
Message-ID: <20170807130306.31530-3-joelaf@google.com> (raw)
In-Reply-To: <20170807130306.31530-1-joelaf@google.com>

When cross compiling, bpf samples use HOSTCC, however what we really want is to
use the cross compiler to build for the cross target since that is what will
help run the BPF target code.  Detect this and also set -static as LDFLAGS
since often times we don't have control over what C library the cross target is
running and its not smart to rely on it.

Signed-off-by: Joel Fernandes <joelaf@google.com>
---
 samples/bpf/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 6c7468eb3684..e5642c8c144d 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -152,6 +152,12 @@ HOSTLOADLIBES_test_map_in_map += -lelf
 LLC ?= llc
 CLANG ?= clang
 
+# Detect that we're cross compiling and use the right compilers and flags
+ifdef CROSS_COMPILE
+HOSTCC = $(CROSS_COMPILE)gcc
+HOSTLDFLAGS += -static
+endif
+
 # Trick to allow make to be run from this directory
 all:
 	$(MAKE) -C ../../ $(CURDIR)/
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

  parent reply	other threads:[~2017-08-07 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 13:03 [PATCH RFC 0/5] add arm64 cross compilation support to BPF samples Joel Fernandes
2017-08-07 13:03 ` [PATCH RFC 1/5] samples/bpf: Use getppid instead of getpgrp for array map stress Joel Fernandes
2017-08-07 13:03 ` Joel Fernandes [this message]
2017-08-07 13:03 ` [PATCH RFC 3/5] samples/bpf: Fix inline asm issues building samples on arm64 Joel Fernandes
2017-08-07 13:03 ` [PATCH RFC 4/5] samples/bpf: Fix pt_regs issues when cross-compiling Joel Fernandes
2017-08-07 13:03 ` [PATCH RFC 5/5] samples/bpf: Add documentation on cross compilation Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170807130306.31530-3-joelaf@google.com \
    --to=joelaf@google.com \
    --cc=alison@she-devel.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=fengc@google.com \
    --cc=jlelli@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).