From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbdHGPHZ (ORCPT ); Mon, 7 Aug 2017 11:07:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40840 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdHGPHY (ORCPT ); Mon, 7 Aug 2017 11:07:24 -0400 Date: Mon, 7 Aug 2017 16:07:14 +0100 From: Mark Brown To: Donglin Peng Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20170807150714.e7aecqskfelp7h5z@sirena.org.uk> References: <1502111504-7996-1-git-send-email-pengdonglin137@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cjvxitc7w7mztkoz" Content-Disposition: inline In-Reply-To: X-Cookie: Did I say 2? I lied. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: compress: Remove duplicated code X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cjvxitc7w7mztkoz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 07, 2017 at 09:18:09PM +0800, Donglin Peng wrote: > The value of the variable new_name is assigned repeatedly. > @@ -737,9 +737,6 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime > *rtd, int num) > } >=20 > /* check client and interface hw capabilities */ > - snprintf(new_name, sizeof(new_name), "%s %s-%d", > - rtd->dai_link->stream_name, codec_dai->name, num); > - Are you sure that this is the assignment that should be deleted, and if so why? Note that it's both conditionally and unconditionally assigned later on... Some words in the commit log about why this copy is removed would be helpful. --cjvxitc7w7mztkoz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmIgiIACgkQJNaLcl1U h9CAOQf/Y1iJKOPnN2qi++MLSwLXoY4eikrqsm6LcD8GyHwZKfRjxDCdhmdaRQLW jB/cs6+P0QiBf1NCRLO9Djtsg2ZHKRgFDbqBddcxVIrV4j14aGMEo3tU6iqSQyqy RjMNF8BQ4+9HzsGxl9y/c5sIpugzD8Lzaj9FlocWikEi23YhlzT0dERqMzzp9Pvy E9vXdcG840w4JxxxUfjncNec/f58M/6E5z0YFwG0p0stRFUEdYOEvGOztTqvPZNF bTcxOY6G1WER6DZb63kssNZEalCL3uKN1oJ/5cC53+f73vaxqdkWFEnH3hoMzaKu zy6LLpQenjV+YGzrFBx+wIyjKb18Mg== =qu/k -----END PGP SIGNATURE----- --cjvxitc7w7mztkoz--