From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdHGPK0 (ORCPT ); Mon, 7 Aug 2017 11:10:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdHGPKY (ORCPT ); Mon, 7 Aug 2017 11:10:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29BA622CAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 7 Aug 2017 12:10:21 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Jin Yao , Linux-kernel@vger.kernel.org, Namhyung Kim , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Peter Zijlstra Subject: Re: [PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym Message-ID: <20170807151021.GR12201@kernel.org> References: <20170806212446.24925-1-milian.wolff@kdab.com> <20170806212446.24925-3-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170806212446.24925-3-milian.wolff@kdab.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Aug 06, 2017 at 11:24:34PM +0200, Milian Wolff escreveu: > The input string is not modified and thus can be passed > in as a pointer to const data. Applied. - Arnaldo > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > --- > tools/perf/util/symbol-elf.c | 2 +- > tools/perf/util/symbol-minimal.c | 2 +- > tools/perf/util/symbol.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c > index 502505cf236a..7cf18f14e152 100644 > --- a/tools/perf/util/symbol-elf.c > +++ b/tools/perf/util/symbol-elf.c > @@ -391,7 +391,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss, struct map * > return 0; > } > > -char *dso__demangle_sym(struct dso *dso, int kmodule, char *elf_name) > +char *dso__demangle_sym(struct dso *dso, int kmodule, const char *elf_name) > { > return demangle_sym(dso, kmodule, elf_name); > } > diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c > index 40bf5d4c0bfd..1a5aa35b0100 100644 > --- a/tools/perf/util/symbol-minimal.c > +++ b/tools/perf/util/symbol-minimal.c > @@ -377,7 +377,7 @@ void symbol__elf_init(void) > > char *dso__demangle_sym(struct dso *dso __maybe_unused, > int kmodule __maybe_unused, > - char *elf_name __maybe_unused) > + const char *elf_name __maybe_unused) > { > return NULL; > } > diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h > index 41ebba9a2eb2..f0b08810d7fa 100644 > --- a/tools/perf/util/symbol.h > +++ b/tools/perf/util/symbol.h > @@ -306,7 +306,7 @@ int dso__load_sym(struct dso *dso, struct map *map, struct symsrc *syms_ss, > int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss, > struct map *map); > > -char *dso__demangle_sym(struct dso *dso, int kmodule, char *elf_name); > +char *dso__demangle_sym(struct dso *dso, int kmodule, const char *elf_name); > > void __symbols__insert(struct rb_root *symbols, struct symbol *sym, bool kernel); > void symbols__insert(struct rb_root *symbols, struct symbol *sym); > -- > 2.13.3