From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 3/9] mfd: axp20x: Add support for AXP813 PMIC
Date: Mon, 7 Aug 2017 16:43:48 +0100 [thread overview]
Message-ID: <20170807154348.plqxm6oht54nb52g@dell> (raw)
In-Reply-To: <20170726082832.16789-4-wens@csie.org>
On Wed, 26 Jul 2017, Chen-Yu Tsai wrote:
> The X-Powers AXP813 PMIC is normally used with Allwinner's A83T SoC.
> It has the same range of functions as other X-Powers PMICs, such as
> DC-DC buck converter and linear regulator outputs, AC-IN and VBUS
> power supplies, power button trigger, GPIOs, ADCs, and a battery
> charger.
>
> Note that the IRQ table given in the datasheet is incorrect: in IRQ
> enable/status registers 1, there are separate IRQs for ACIN and VBUS,
> instead of bits [7:5] being the same as bits [4:2]. So it shares the
> same IRQs as the AXP803, rather than the AXP288.
>
> This patch adds basic mfd support for it, with only the power button
> enabled.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/axp20x-rsb.c | 1 +
> drivers/mfd/axp20x.c | 22 ++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 29 +++++++++++++++++++++++++++++
> 3 files changed, 52 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/axp20x-rsb.c b/drivers/mfd/axp20x-rsb.c
> index fd5c7267b136..7ddbd9e8dd03 100644
> --- a/drivers/mfd/axp20x-rsb.c
> +++ b/drivers/mfd/axp20x-rsb.c
> @@ -64,6 +64,7 @@ static const struct of_device_id axp20x_rsb_of_match[] = {
> { .compatible = "x-powers,axp803", .data = (void *)AXP803_ID },
> { .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
> { .compatible = "x-powers,axp809", .data = (void *)AXP809_ID },
> + { .compatible = "x-powers,axp813", .data = (void *)AXP813_ID },
> { },
> };
> MODULE_DEVICE_TABLE(of, axp20x_rsb_of_match);
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 917b6ddc4f15..ec4271ca065c 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -44,6 +44,7 @@ static const char * const axp20x_model_names[] = {
> "AXP803",
> "AXP806",
> "AXP809",
> + "AXP813",
> };
>
> static const struct regmap_range axp152_writeable_ranges[] = {
> @@ -870,6 +871,14 @@ static struct mfd_cell axp809_cells[] = {
> },
> };
>
> +static struct mfd_cell axp813_cells[] = {
> + {
> + .name = "axp20x-pek",
> + .num_resources = ARRAY_SIZE(axp803_pek_resources),
> + .resources = axp803_pek_resources,
> + }
> +};
> +
> static struct axp20x_dev *axp20x_pm_power_off;
> static void axp20x_power_off(void)
> {
> @@ -956,6 +965,19 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
> axp20x->regmap_cfg = &axp22x_regmap_config;
> axp20x->regmap_irq_chip = &axp809_regmap_irq_chip;
> break;
> + case AXP813_ID:
> + axp20x->nr_cells = ARRAY_SIZE(axp813_cells);
> + axp20x->cells = axp813_cells;
> + axp20x->regmap_cfg = &axp288_regmap_config;
> + /*
> + * The IRQ table given in the datasheet is incorrect.
> + * In IRQ enable/status registers 1, there are separate
> + * IRQs for ACIN and VBUS, instead of bits [7:5] being
> + * the same as bits [4:2]. So it shares the same IRQs
> + * as the AXP803, rather than the AXP288.
> + */
> + axp20x->regmap_irq_chip = &axp803_regmap_irq_chip;
> + break;
> default:
> dev_err(dev, "unsupported AXP20X ID %lu\n", axp20x->variant);
> return -EINVAL;
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index 965b027e31b3..e9c908c4fba8 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -23,6 +23,7 @@ enum axp20x_variants {
> AXP803_ID,
> AXP806_ID,
> AXP809_ID,
> + AXP813_ID,
> NR_AXP20X_VARIANTS,
> };
>
> @@ -387,6 +388,34 @@ enum {
> AXP803_REG_ID_MAX,
> };
>
> +enum {
> + AXP813_DCDC1 = 0,
> + AXP813_DCDC2,
> + AXP813_DCDC3,
> + AXP813_DCDC4,
> + AXP813_DCDC5,
> + AXP813_DCDC6,
> + AXP813_DCDC7,
> + AXP813_ALDO1,
> + AXP813_ALDO2,
> + AXP813_ALDO3,
> + AXP813_DLDO1,
> + AXP813_DLDO2,
> + AXP813_DLDO3,
> + AXP813_DLDO4,
> + AXP813_ELDO1,
> + AXP813_ELDO2,
> + AXP813_ELDO3,
> + AXP813_FLDO1,
> + AXP813_FLDO2,
> + AXP813_FLDO3,
> + AXP813_RTC_LDO,
> + AXP813_LDO_IO0,
> + AXP813_LDO_IO1,
> + AXP813_SW,
> + AXP813_REG_ID_MAX,
> +};
> +
> /* IRQs */
> enum {
> AXP152_IRQ_LDO0IN_CONNECT = 1,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-08-07 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 8:28 [PATCH v2 0/9] mfd: axp20x: Add basic support for AXP813 Chen-Yu Tsai
2017-07-26 8:28 ` [PATCH v2 1/9] dt-bindings: mfd: axp20x: Add AXP806 to supported list of chips Chen-Yu Tsai
2017-08-07 15:43 ` Lee Jones
2017-07-26 8:28 ` [PATCH v2 2/9] dt-bindings: mfd: axp20x: Introduce bindings for AXP813 Chen-Yu Tsai
2017-08-07 15:43 ` Lee Jones
2017-07-26 8:28 ` [PATCH v2 3/9] mfd: axp20x: Add support for AXP813 PMIC Chen-Yu Tsai
2017-08-07 15:43 ` Lee Jones [this message]
2017-07-26 8:28 ` [PATCH v2 4/9] mfd: axp20x: use correct platform device id for many PEK Chen-Yu Tsai
2017-08-07 15:43 ` Lee Jones
2017-07-26 8:28 ` [PATCH v2 5/9] ARM: sun8i: a83t: Add device node and pinmux setting for RSB controller Chen-Yu Tsai
2017-07-26 8:28 ` [PATCH v2 6/9] ARM: sun8i: a83t: cubietruck-plus: Enable PMIC part of AXP818 PMIC Chen-Yu Tsai
2017-07-26 8:28 ` [PATCH v2 7/9] ARM: sun8i: a83t: cubietruck-plus: Enable AC100 combo chip in " Chen-Yu Tsai
2017-07-26 8:28 ` [PATCH v2 8/9] ARM: sun8i: a83t: h8homlet-v2: Enable PMIC part of " Chen-Yu Tsai
2017-07-26 8:28 ` [PATCH v2 9/9] ARM: sun8i: a83t: h8homlet-v2: Enable AC100 combo chip in " Chen-Yu Tsai
2017-07-26 8:32 ` [PATCH v2 0/9] mfd: axp20x: Add basic support for AXP813 Maxime Ripard
2017-08-08 4:05 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807154348.plqxm6oht54nb52g@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).