From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbdHIDfp (ORCPT ); Tue, 8 Aug 2017 23:35:45 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbdHIDfo (ORCPT ); Tue, 8 Aug 2017 23:35:44 -0400 Date: Tue, 08 Aug 2017 20:35:40 -0700 (PDT) Message-Id: <20170808.203540.2238751604302920304.davem@davemloft.net> To: joelaf@google.com Cc: linux-kernel@vger.kernel.org, fengc@google.com, alison@she-devel.com, Juri.Lelli@arm.com, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org Subject: Re: [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64 From: David Miller In-Reply-To: References: <20170807130602.31785-4-joelaf@google.com> <20170807.112840.395506747161262549.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Aug 2017 20:35:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joel Fernandes Date: Mon, 7 Aug 2017 18:20:49 -0700 > On Mon, Aug 7, 2017 at 11:28 AM, David Miller wrote: >> The amount of hellish hacks we are adding to deal with this is getting >> way out of control. > > I agree with you that hellish hacks are being added which is why it > keeps breaking. I think one of the things my series does is to add > back inclusion of asm headers that were previously removed (that is > the worst hellish hack in my opinion that existing in mainline). So in > that respect my patch is an improvement and makes it possible to build > for arm64 platforms (which is currently broken in mainline). Yeah that is a problem. Perhaps another avenue of attack is to separate "type" header files from stuff that has functiond declarations and inline assembler code.