From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbdHHAOs (ORCPT ); Mon, 7 Aug 2017 20:14:48 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:15592 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdHHAOq (ORCPT ); Mon, 7 Aug 2017 20:14:46 -0400 X-AuditID: b6c32a37-f79886d000004f16-95-598902749415 Mime-Version: 1.0 Subject: RE: [PATCH] devfreq: add error check for sscanf in userspace governor Reply-To: myungjoo.ham@samsung.com From: MyungJoo Ham To: Kyungmin Park , "rafael.j.wysocki@intel.com" , Chanwoo Choi CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "gsantosh@qti.qualcomm.com" , "gsantosh@codeaurora.org" , "skannan@quicinc.com" , "rgottimu@qti.qualcomm.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <1502111205-22560-2-git-send-email-gsantosh@codeaurora.org> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Illegal-Object: Syntax error in X-Sender: address found on vger.kernel.org: X-Sender: =?utf-8?B?U2Ftc3VuZyBFbGVjdHJvbmljcxtBcnRpZmljaWFsIEludA==?= ^-Extraneous program text X-Sender-IP: 10.113.73.204 X-Local-Sender: =?UTF-8?B?7ZWo66qF7KO8G0FydGlmaWNpYWwgSW50ZWxsaWdlbmNlIDNMYWIoUy9X?= =?UTF-8?B?7IS87YSwKRvsgrzshLHsoITsnpAbUHJpbmNpcGFsIEVuZ2lu?= =?UTF-8?B?ZWVy?= X-Global-Sender: =?UTF-8?B?TXl1bmdKb28gSGFtG0FydGlmaWNpYWwgSW50ZWxsaWdlbmNlIDNMYWIu?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbUHJpbmNpcGFsIEVuZ2lu?= =?UTF-8?B?ZWVy?= X-Sender-Code: =?UTF-8?B?QzEwGxtDMTBWODI5MQ==?= Message-ID: <20170808001443epcms1p53655025662e843eab56aca33554b09df@epcms1p5> Date: Tue, 08 Aug 2017 00:14:43 +0000 X-CMS-MailID: 20170808001443epcms1p53655025662e843eab56aca33554b09df Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-MTR: 20170808001443epcms1p53655025662e843eab56aca33554b09df CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0gTcRzvt9vjFFfXMvu2yMaRgZJzt3ycolEkcaTByP7IouzSa0ru0W5W BpYUppmv0RPRsuyxStLJalYWsSIkszTJHqgpYmG1gmxRiNW2m9R/n/v8Po/v9/jimOKsVIkX GK2cxcgWktJQ8a2H0epYq+hotqarFqNfff8gob2P2sV02/A3jO459FlG999pkNKT1Y8QPWb3 yOhS5xCip5qqJatCmP6aahHT3DkhYi6cfI8YW+cBpsZ5DTGT7ZE66WYuNZ9j8ziLijPmmvIK jPo0MiMrZ01OQqKGiqWS6SRSZWQNXBqZnqmLXVtQ6BuKVO1hC4t8lI7leTJuZarFVGTlVPkm 3ppGbqEorZrSJKm1Wq06fsXWFG2CT7Kdy2+6N4SZe7F9915cl5WiKVElCsGBiIcnR7uQgCOg d7hVWolCcQXRgeC066O4EuG4nJgL0x3z/Jp5hA5s735K/FhBkFD65j4m8HFQMXIrkCMlYuFm 25DYj8OJOgRtfdn+TIwYEEGX/btMKJPDmfJxsYAXgevKzYA5hGDAO/EyONB8eHPdE9QDDH7q DQ4dCae8LdiM5uvjc0F9OJQN9wT5uTDy6y7yFwNRhmDQ+T4YpIS3zQMi4eEygub+cZnwcQVB +UWH1L8y+Pa57VrjN8iJ9TDVcDzQLCaioK5zJigdnowOB9owYgm4PA2Y34oR0dB6J06QpMFh 72+JIJkNX7xVEoFfBu67F2V1aGn9v/9b/19Q/b+gJoRdQxGcmTfoOZ4yr1DzrIEvMurVuSZD OwrcZkxSB2p7lulGBI7IMLl9Z0W2QsLu4YsNbgQ4RobLa//4KHkeW7yfs5hyLEWFHO9GCb59 bJhyfq7Jd+lGaw4Vn6yJT9T6bi6ZosgF8ojWgU0KQs9auV0cZ+YsMz4RHqIsRamOn6cXvP6y fUdk47SNaTYnX03ZvTDOvdrUPkf1o8ZVMTJY7uk73+GkWsKiuzeWeDLslyYlVFJGxLoSWWPV Ef2WDba+rIPdjtGPz5V1DqdXdxyX7j3f4niA39j86WwV8y4qRpM+a3nv4tpjn+2y16KwZcXG JSdOXrVGJjylGse2kWI+n6ViMAvP/gUR2NB0sQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170807130735epcas5p4386af2ade3bd98b67fc5a9c956152c7d X-RootMTR: 20170807130735epcas5p4386af2ade3bd98b67fc5a9c956152c7d References: <1502111205-22560-2-git-send-email-gsantosh@codeaurora.org> <1502111205-22560-1-git-send-email-gsantosh@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > store_freq function of devfreq userspace governor > executes further, even if error is returned from sscanf, > this will result in setting up wrong frequency value. > > Add proper error check to bail out if any error is returned. > > Signed-off-by: Santosh Mardi Acked-by: MyungJoo Ham > --- > drivers/devfreq/governor_userspace.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)