From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbdHJJZf (ORCPT ); Thu, 10 Aug 2017 05:25:35 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36522 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdHJJZe (ORCPT ); Thu, 10 Aug 2017 05:25:34 -0400 Date: Thu, 10 Aug 2017 11:25:23 +0200 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, tglx@linutronix.de, walken@google.com, boqun.feng@gmail.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, npiggin@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v8 11/14] lockdep: Apply crossrelease to PG_locked locks Message-ID: <20170810092523.ktie2iqhefw5saop@hirez.programming.kicks-ass.net> References: <1502089981-21272-1-git-send-email-byungchul.park@lge.com> <1502089981-21272-12-git-send-email-byungchul.park@lge.com> <20170810013501.GY20323@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810013501.GY20323@X58A-UD3R> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2017 at 10:35:02AM +0900, Byungchul Park wrote: > On Mon, Aug 07, 2017 at 04:12:58PM +0900, Byungchul Park wrote: > > Although lock_page() and its family can cause deadlock, the lock > > correctness validator could not be applied to them until now, becasue > > things like unlock_page() might be called in a different context from > > the acquisition context, which violates lockdep's assumption. > > > > Thanks to CONFIG_LOCKDEP_CROSSRELEASE, we can now apply the lockdep > > detector to page locks. Applied it. > > Is there any reason excluding applying it into PG_locked? Wanted to start small..