From: Sean Paul <seanpaul@chromium.org>
To: Sandy Huang <sandy.huang@rock-chips.com>
Cc: Sean Paul <seanpaul@chromium.org>,
Sandy Huang <hjc@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Mark Yao <mark.yao@rock-chips.com>
Subject: Re: [PATCH 3/3] drm/rockchip: Add support for Rockchip Soc LVDS
Date: Thu, 10 Aug 2017 14:05:19 -0400 [thread overview]
Message-ID: <20170810180519.ezndiczwpheac4ih@art_vandelay> (raw)
In-Reply-To: <d24020c6-ef7f-6c7d-b655-99e56c8760d5@rock-chips.com>
On Thu, Aug 10, 2017 at 05:35:52PM +0800, Sandy Huang wrote:
> Hi Sean Paul,
> Thanks for your review.
>
> 在 2017/8/10 3:58, Sean Paul 写道:
> > On Wed, Aug 09, 2017 at 06:00:59PM +0800, Sandy Huang wrote:
> > > This adds support for Rockchip soc lvds found on rk3288
> > > Based on the patches from Mark yao and Heiko Stuebner
> > >
> > > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > > Signed-off-by: Mark yao <mark.yao@rock-chips.com>
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > ---
> > > drivers/gpu/drm/rockchip/Kconfig | 9 +
> > > drivers/gpu/drm/rockchip/Makefile | 1 +
> > > drivers/gpu/drm/rockchip/rockchip_lvds.c | 734 +++++++++++++++++++++++++++++++
> > > drivers/gpu/drm/rockchip/rockchip_lvds.h | 112 +++++
> > > 4 files changed, 856 insertions(+)
> > > create mode 100644 drivers/gpu/drm/rockchip/rockchip_lvds.c
> > > create mode 100644 drivers/gpu/drm/rockchip/rockchip_lvds.h
> > >
<snip />
> > > diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> > > new file mode 100644
> > > index 0000000..a4ad3f0
> > > --- /dev/null
> > > +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
<snip />
> > > + lvds->drm_dev = drm_dev;
> > > + port = of_graph_get_port_by_id(dev->of_node, 1);
> > > + if (!port) {
> > > + dev_err(dev, "can't found port point, please init lvds panel port!\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + for_each_child_of_node(port, endpoint) {
> > > + remote = of_graph_get_remote_port_parent(endpoint);
> > > + if (!remote) {
> > > + dev_err(dev, "can't found panel node, please init!\n");
> > > + ret = -EINVAL;
> > > + goto err_put_port;
> > > + }
> > > + if (!of_device_is_available(remote)) {
> > > + of_node_put(remote);
> > > + remote = NULL;
> > > + continue;
> > > + }
> > > + break;
> > > + }
> > > + if (!remote) {
> > > + dev_err(dev, "can't found remote node, please init!\n");
> > > + ret = -EINVAL;
> > > + goto err_put_port;
> > > + }
> > > +
> > > + lvds->panel = of_drm_find_panel(remote);
> > > + if (!lvds->panel)
> > > + lvds->bridge = of_drm_find_bridge(remote);
> >
> > drm_of_find_panel_or_bridge()
> >
>
> because the lvds ports maybe connect to lvds-panel or connect to
> rk1000(which is convert RGB to CVBS output), so i have to get the remote
> port parent and check the status, and final get the active remote point.
>
> lvds_panel: lvds-panel {
> status = "disabled";
> ports {
> panel_in_lvds: endpoint {
> remote-endpoint = <&lvds_out_panel>;
> };
> };
> };
>
> rk1000: rk1000@0xff000000 {
> status = "okay";
> ports {
> rk1000_in_lvds: endpoint {
> remote-endpoint = <&lvds_out_panel>;
> };
> };
> };
>
> &lvds {
> status = "okay";
> ports {
> lvds_out: port@1 {
> reg = <1>;
> lvds_out_panel: endpoint@0 {
> reg = <0>;
> remote-endpoint = <&panel_in_lvds>;
> };
> lvds_out_rk1000: endpoint@1 {
> reg = <1>;
> remote-endpoint = <&rk1000_in_lvds>;
> };
> };
>
> };
> };
Hi Sandy,
Forgive me, this is probably a stupid question. I don't see how this usecase is
unique from the other users of drm_of_find_panel_or_bridge. Couldn't you change
your devicetree bindings to conform to something drm_of_find_panel_or_bridge()
can work with?
Thank you,
Sean
<snip />
> > > --
> > > 2.7.4
> > >
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
>
> --
> Best Regard
>
> 黄家钗
> Sandy Huang
> 福州瑞芯微电子股份有限公司-图形与显示系统部门
> Fuzhou Rockchip Electronics Co.Ltd - Graphics & Display Dept.
> Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
> No. 21 Building, A District, No.89,software Boulevard
> Fuzhou,Fujian,PRC
> Tel:+86 0591-87884919 8690
> E-mail:hjc@rock-chips.com
>
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2017-08-10 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 10:00 [PATCH 0/3] drm/rockchip: lvds: add support Rockchip Soc LVDS Sandy Huang
2017-08-09 10:00 ` [PATCH 1/3] dt-bindings: display: Add Document for " Sandy Huang
2017-08-11 15:38 ` Philipp Zabel
2017-08-14 4:04 ` Sandy Huang
2017-08-09 10:00 ` [PATCH 2/3] ARM: dts: Add LVDS info for rk3288 Sandy Huang
2017-08-09 10:00 ` [PATCH 3/3] drm/rockchip: Add support for Rockchip Soc LVDS Sandy Huang
2017-08-09 19:58 ` Sean Paul
2017-08-10 9:35 ` Sandy Huang
2017-08-10 18:05 ` Sean Paul [this message]
2017-08-11 2:15 ` Sandy Huang
2017-08-11 14:44 ` Sean Paul
2017-08-14 3:59 ` Sandy Huang
2017-08-10 9:49 Sandy Huang
2017-08-10 9:55 ` Sandy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810180519.ezndiczwpheac4ih@art_vandelay \
--to=seanpaul@chromium.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=sandy.huang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).