From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: linux-mips@linux-mips.org,
Miodrag Dinic <miodrag.dinic@imgtec.com>,
Goran Ferenc <goran.ferenc@imgtec.com>,
Aleksandar Markovic <aleksandar.markovic@imgtec.com>,
Alessandro Zummo <a.zummo@towertech.it>, Bo Hu <bohu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Douglas Leung <douglas.leung@imgtec.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Hogan <james.hogan@imgtec.com>,
Jin Qian <jinqian@google.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Paul Burton <paul.burton@imgtec.com>,
Petar Jovanovic <petar.jovanovic@imgtec.com>,
Raghu Gandham <raghu.gandham@imgtec.com>
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Date: Thu, 10 Aug 2017 22:34:30 +0200 [thread overview]
Message-ID: <20170810203430.zgtxvi7uaqmg4dzr@piout.net> (raw)
In-Reply-To: <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com>
Hi,
On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 8 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 243 insertions(+)
> create mode 100644 drivers/rtc/rtc-goldfish.c
>
Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-10 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 16:53 [PATCH v3 0/8] MIPS: Add virtual Ranchu board as a generic-based board Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 1/8] Documentation: Add device tree binding for Goldfish RTC driver Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 2/8] MIPS: ranchu: Add " Aleksandar Markovic
2017-07-23 23:50 ` kbuild test robot
2017-07-24 2:14 ` kbuild test robot
2017-08-10 20:34 ` Alexandre Belloni [this message]
2017-08-11 16:46 ` Miodrag Dinic
2017-08-14 12:45 ` Aleksandar Markovic
2017-08-14 13:13 ` Alexandre Belloni
2017-07-21 16:53 ` [PATCH v3 3/8] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 4/8] MIPS: ranchu: Add " Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 5/8] MIPS: ranchu: Add Ranchu as a new generic-based board Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 6/8] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 7/8] video: goldfishfb: Add support for device tree bindings Aleksandar Markovic
2017-07-21 16:53 ` [PATCH v3 8/8] MIPS: Unselect ARCH_MIGHT_HAVE_PC_SERIO if MIPS_GENERIC Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810203430.zgtxvi7uaqmg4dzr@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=aleksandar.markovic@imgtec.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=bohu@google.com \
--cc=davem@davemloft.net \
--cc=douglas.leung@imgtec.com \
--cc=goran.ferenc@imgtec.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=jinqian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miodrag.dinic@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=petar.jovanovic@imgtec.com \
--cc=raghu.gandham@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).