linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: matthew.gerlach@linux.intel.com
Cc: vndao@altera.com, dwmw2@infradead.org,
	computersforpeace@gmail.com, boris.brezillon@free-electrons.com,
	marek.vasut@gmail.com, richard@nod.at,
	cyrille.pitchen@wedev4u.fr, mark.rutland@arm.com,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	davem@davemloft.net, mchehab@kernel.org,
	linux-fpga@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mtd: Altera ASMI Parallel II IP Core
Date: Thu, 10 Aug 2017 15:35:02 -0500	[thread overview]
Message-ID: <20170810203502.5s2evtamkbolluae@rob-hp-laptop> (raw)
In-Reply-To: <1502043844-3626-2-git-send-email-matthew.gerlach@linux.intel.com>

On Sun, Aug 06, 2017 at 11:24:02AM -0700, matthew.gerlach@linux.intel.com wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> 
> Device Tree bindinds for Altera ASMI Parallel II IP Core.

s/bindinds/bindings/

> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
>  .../devicetree/bindings/mtd/altera-asmip2.txt      | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/altera-asmip2.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/altera-asmip2.txt b/Documentation/devicetree/bindings/mtd/altera-asmip2.txt
> new file mode 100644
> index 0000000..3380366
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/altera-asmip2.txt
> @@ -0,0 +1,22 @@
> +* Altera ASMI Parallel II IP Core
> +
> +Required properties:
> +- compatible : Should be "altr,asmi_parallel2".

s/_/-/

> +- reg : A tuple consisting of a physical address and length.
> +
> +Optional subnodes:
> +Subnodes of the Altera ASMI Paralllel II IP Core are spi slave nodes.

But this is not a general purpose SPI controller?

> +- reg : chip select value
> +- label : optional user friendly label
> +
> +Example:
> +
> +qspi: spi@a0001000 {
> +	compatible = "altr,asmi_parallel2";
> +	reg = <0xa0001000 0x10>;
> +
> +	flash@0 {

This should have a compatible.

> +		reg = <0>;
> +		label = "FPGA Image";
> +	};
> +};
> -- 
> 2.7.4
> 

  reply	other threads:[~2017-08-10 20:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06 18:24 [PATCH 0/3] Altera ASMI Parallel II IP Core matthew.gerlach
2017-08-06 18:24 ` [PATCH 1/2] dt-bindings: mtd: " matthew.gerlach
2017-08-10 20:35   ` Rob Herring [this message]
2017-08-14 16:38     ` matthew.gerlach
2017-08-06 18:24 ` [PATCH 2/2] mtd: spi-nor: " matthew.gerlach
2017-08-06 19:27   ` Marek Vasut
2017-08-07 15:21     ` matthew.gerlach
2017-08-11 17:20   ` Cyrille Pitchen
2017-08-15 17:20     ` matthew.gerlach
2017-08-15 20:08       ` Cyrille Pitchen
2017-08-27 15:42         ` matthew.gerlach
2017-08-06 18:24 ` [PATCH 3/3] fpga: intel: Add QSPI FPGA Management Entity Feature matthew.gerlach
2017-08-07 15:47   ` Alan Tull
2017-08-14 13:30     ` Wu, Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810203502.5s2evtamkbolluae@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=mchehab@kernel.org \
    --cc=richard@nod.at \
    --cc=vndao@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).