linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Stefan Agner <stefan@agner.ch>, Jan Kara <jack@suse.cz>,
	Daeho Jeong <daeho.jeong@samsung.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix clang build regression
Date: Mon, 14 Aug 2017 08:29:38 -0400	[thread overview]
Message-ID: <20170814122938.caz2j2rqjcuxfqoz@thunk.org> (raw)
In-Reply-To: <48473218.z3lFQE8RDq@localhost.localdomain>

On Sat, Aug 12, 2017 at 02:09:29PM +0530, Chandan Rajendra wrote:
> On Monday, August 7, 2017 4:26:51 PM IST Arnd Bergmann wrote:
> > As Stefan pointed out, I misremembered what clang can do specifically,
> > and it turns out that the variable-length array at the end of the
> > structure did not work (a flexible array would have worked here
> > but not solved the problem):
> > 
> > fs/ext4/mballoc.c:2303:17: error: fields must have a constant size:
> > 'variable length array in structure' extension will never be supported
> >                 ext4_grpblk_t counters[blocksize_bits + 2];
> > 
> > This reverts part of my previous patch, using a fixed-size array
> > again, but keeping the check for the array overflow.
> > 
> > Fixes: 2df2c3402fc8 ("ext4: fix warning about stack corruption")
> > Reported-by: Stefan Agner <stefan@agner.ch>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I executed xfstests on a ppc64 machine with both 4k and 64k block size 
> combination.
> 
> Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>

Thanks, applied.

						- Ted

      reply	other threads:[~2017-08-14 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 10:56 [PATCH] ext4: fix clang build regression Arnd Bergmann
2017-08-12  8:39 ` Chandan Rajendra
2017-08-14 12:29   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814122938.caz2j2rqjcuxfqoz@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=arnd@arndb.de \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=daeho.jeong@samsung.com \
    --cc=darrick.wong@oracle.com \
    --cc=jack@suse.cz \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).