From: Mark Rutland <mark.rutland@arm.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: will.deacon@arm.com, jonathan.cameron@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH v4 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver
Date: Tue, 15 Aug 2017 10:50:06 +0100 [thread overview]
Message-ID: <20170815095005.GB6090@leverpostej> (raw)
In-Reply-To: <1500984642-204676-2-git-send-email-zhangshaokun@hisilicon.com>
Hi,
On Tue, Jul 25, 2017 at 08:10:37PM +0800, Shaokun Zhang wrote:
> This patch adds documentation for the uncore PMUs on HiSilicon SoC.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> Signed-off-by: Anurup M <anurup.m@huawei.com>
> ---
> Documentation/perf/hisi-pmu.txt | 52 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/perf/hisi-pmu.txt
>
> diff --git a/Documentation/perf/hisi-pmu.txt b/Documentation/perf/hisi-pmu.txt
> new file mode 100644
> index 0000000..f45a03d
> --- /dev/null
> +++ b/Documentation/perf/hisi-pmu.txt
> @@ -0,0 +1,52 @@
> +HiSilicon SoC uncore Performance Monitoring Unit (PMU)
> +======================================================
> +The HiSilicon SoC chip comprehends various independent system device PMUs
Nit: s/comprehends/comprises/ would be easier to read.
> +such as L3 cache (L3C), Hydra Home Agent (HHA) and DDRC. These PMUs are
> +independent and have hardware logic to gather statistics and performance
> +information.
> +
> +HiSilicon SoC encapsulates multiple CPU and IO dies. Each CPU cluster
Nit: The Hisilicon SoC
> +(CCL) is made up of 4 cpu cores sharing one L3 cache; Each CPU die is
Nit: s/Each/each/
> +called Super CPU cluster (SCCL) and is made up of 6 CCLs. Each SCCL has
> +two HHAs (0 - 1) and four DDRCs (0 - 3), respectively.
> +
> +HiSilicon SoC uncore PMU driver
> +---------------------------------------
> +Each device PMU has separate registers for event counting, control and
> +interrupt, and the PMU driver shall register perf PMU drivers like L3C,
> +HHA and DDRC etc. The available events and configuration options shall
> +be described in the sysfs, see /sys/devices/hisi_*
What exactly its exposed under /sys/devices/hisi_* ?
> or /sys/bus/
> +event_source/devices/hisi_*.
Please don't wrap paths; keep this on one line.
> +The "perf list" command shall list the available events from sysfs.
> +
> +Each L3C, HHA and DDRC in one SCCL are registered as an separate PMU with perf.
> +The PMU name will appear in event listing as hisi_module <index-id>_<sccl-id>.
> +where "index-id" is the index of module and "sccl-id" is the identifier of
> +the SCCL.
> +e.g. hisi_l3c0_1/rd_hit_cpipe is READ_HIT_CPIPE event of L3C index #0 and SCCL
> +ID #1.
> +e.g. hisi_hha0_1/rx_operations is RX_OPERATIONS event of HHA index #0 and SCCL
> +ID #1.
It would make more sense for this to be hierarichal, e.g. hisi_sccl{X}_l3c{Y}.
Other than the above nits, this documentation is very useful. Thanks for
putting this together.
Thanks,
Mark.
next prev parent reply other threads:[~2017-08-15 9:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 12:10 [PATCH v4 0/6] Add HiSilicon SoC uncore Performance Monitoring Unit driver Shaokun Zhang
2017-07-25 12:10 ` [PATCH v4 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver Shaokun Zhang
2017-08-15 9:50 ` Mark Rutland [this message]
2017-08-17 2:30 ` Zhangshaokun
2017-08-17 3:56 ` Jonathan Cameron
2017-07-25 12:10 ` [PATCH v4 2/6] perf: hisi: Add support for HiSilicon SoC uncore " Shaokun Zhang
2017-08-15 10:16 ` Mark Rutland
2017-08-17 3:08 ` Zhangshaokun
2017-07-25 12:10 ` [PATCH v4 3/6] perf: hisi: Add support for HiSilicon SoC L3C " Shaokun Zhang
2017-08-15 10:41 ` Mark Rutland
2017-08-17 3:31 ` Zhangshaokun
2017-07-25 12:10 ` [PATCH v4 4/6] perf: hisi: Add support for HiSilicon SoC HHA " Shaokun Zhang
2017-08-15 11:05 ` Mark Rutland
2017-08-17 3:38 ` Zhangshaokun
2017-07-25 12:10 ` [PATCH v4 5/6] perf: hisi: Add support for HiSilicon SoC DDRC " Shaokun Zhang
2017-08-15 13:02 ` Mark Rutland
2017-08-17 3:40 ` Zhangshaokun
2017-07-25 12:10 ` [PATCH v4 6/6] arm64: MAINTAINERS: hisi: Add HiSilicon SoC PMU support Shaokun Zhang
2017-08-07 8:57 ` [PATCH v4 0/6] Add HiSilicon SoC uncore Performance Monitoring Unit driver Zhangshaokun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815095005.GB6090@leverpostej \
--to=mark.rutland@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=will.deacon@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).