From: Vinod Koul <vinod.koul@intel.com>
To: Anup Patel <anup.patel@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 10/16] dmaengine: bcm-sba-raid: Alloc resources before registering DMA device
Date: Thu, 17 Aug 2017 12:08:12 +0530 [thread overview]
Message-ID: <20170817063812.GA3053@localhost> (raw)
In-Reply-To: <1501583880-32072-11-git-send-email-anup.patel@broadcom.com>
On Tue, Aug 01, 2017 at 04:07:54PM +0530, Anup Patel wrote:
> We should allocate DMA channel resources before registering the
> DMA device in sba_probe() because we can get DMA request soon
> after registering the DMA device. If DMA channel resources are
> not allocated before first DMA request then SBA-RAID driver will
> crash.
>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> ---
> drivers/dma/bcm-sba-raid.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> index f6616da..f14ed0a 100644
> --- a/drivers/dma/bcm-sba-raid.c
> +++ b/drivers/dma/bcm-sba-raid.c
> @@ -1478,13 +1478,13 @@ static int sba_prealloc_channel_resources(struct sba_device *sba)
> int i, j, ret = 0;
> struct sba_request *req = NULL;
>
> - sba->resp_base = dma_alloc_coherent(sba->dma_dev.dev,
> + sba->resp_base = dma_alloc_coherent(sba->mbox_dev,
how does this qualify as move before registering, you seem to be using
different device now
> sba->max_resp_pool_size,
> &sba->resp_dma_base, GFP_KERNEL);
> if (!sba->resp_base)
> return -ENOMEM;
>
> - sba->cmds_base = dma_alloc_coherent(sba->dma_dev.dev,
> + sba->cmds_base = dma_alloc_coherent(sba->mbox_dev,
> sba->max_cmds_pool_size,
> &sba->cmds_dma_base, GFP_KERNEL);
> if (!sba->cmds_base) {
> @@ -1534,11 +1534,11 @@ static int sba_prealloc_channel_resources(struct sba_device *sba)
> return 0;
>
> fail_free_cmds_pool:
> - dma_free_coherent(sba->dma_dev.dev,
> + dma_free_coherent(sba->mbox_dev,
> sba->max_cmds_pool_size,
> sba->cmds_base, sba->cmds_dma_base);
> fail_free_resp_pool:
> - dma_free_coherent(sba->dma_dev.dev,
> + dma_free_coherent(sba->mbox_dev,
> sba->max_resp_pool_size,
> sba->resp_base, sba->resp_dma_base);
> return ret;
> @@ -1547,9 +1547,9 @@ static int sba_prealloc_channel_resources(struct sba_device *sba)
> static void sba_freeup_channel_resources(struct sba_device *sba)
> {
> dmaengine_terminate_all(&sba->dma_chan);
> - dma_free_coherent(sba->dma_dev.dev, sba->max_cmds_pool_size,
> + dma_free_coherent(sba->mbox_dev, sba->max_cmds_pool_size,
> sba->cmds_base, sba->cmds_dma_base);
> - dma_free_coherent(sba->dma_dev.dev, sba->max_resp_pool_size,
> + dma_free_coherent(sba->mbox_dev, sba->max_resp_pool_size,
> sba->resp_base, sba->resp_dma_base);
> sba->resp_base = NULL;
> sba->resp_dma_base = 0;
> @@ -1737,15 +1737,15 @@ static int sba_probe(struct platform_device *pdev)
> }
> }
>
> - /* Register DMA device with linux async framework */
> - ret = sba_async_register(sba);
> + /* Prealloc channel resource */
> + ret = sba_prealloc_channel_resources(sba);
> if (ret)
> goto fail_free_mchans;
>
> - /* Prealloc channel resource */
> - ret = sba_prealloc_channel_resources(sba);
> + /* Register DMA device with Linux async framework */
> + ret = sba_async_register(sba);
> if (ret)
> - goto fail_async_dev_unreg;
> + goto fail_free_resources;
>
> /* Print device info */
> dev_info(sba->dev, "%s using SBAv%d and %d mailbox channels",
> @@ -1754,8 +1754,8 @@ static int sba_probe(struct platform_device *pdev)
>
> return 0;
>
> -fail_async_dev_unreg:
> - dma_async_device_unregister(&sba->dma_dev);
> +fail_free_resources:
> + sba_freeup_channel_resources(sba);
> fail_free_mchans:
> for (i = 0; i < sba->mchans_count; i++)
> mbox_free_channel(sba->mchans[i]);
> @@ -1767,10 +1767,10 @@ static int sba_remove(struct platform_device *pdev)
> int i;
> struct sba_device *sba = platform_get_drvdata(pdev);
>
> - sba_freeup_channel_resources(sba);
> -
> dma_async_device_unregister(&sba->dma_dev);
>
> + sba_freeup_channel_resources(sba);
> +
> for (i = 0; i < sba->mchans_count; i++)
> mbox_free_channel(sba->mchans[i]);
>
> --
> 2.7.4
>
--
~Vinod
next prev parent reply other threads:[~2017-08-17 6:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 10:37 [PATCH v2 00/16] Broadcom SBA-RAID driver improvements Anup Patel
2017-08-01 10:37 ` [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments Anup Patel
2017-08-17 3:44 ` Vinod Koul
2017-08-18 4:54 ` Anup Patel
2017-08-01 10:37 ` [PATCH v2 02/16] dmaengine: bcm-sba-raid: Reduce locking context in sba_alloc_request() Anup Patel
2017-08-01 10:37 ` [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Anup Patel
2017-08-17 3:45 ` Vinod Koul
2017-08-18 4:56 ` Anup Patel
2017-08-18 5:25 ` Vinod Koul
2017-08-18 6:05 ` Anup Patel
2017-08-01 10:37 ` [PATCH v2 04/16] dmaengine: bcm-sba-raid: Remove redundant next_count from sba_request Anup Patel
2017-08-01 10:37 ` [PATCH v2 05/16] dmaengine: bcm-sba-raid: Remove redundant resp_dma " Anup Patel
2017-08-01 10:37 ` [PATCH v2 06/16] dmaengine: bcm-sba-raid: Remove reqs_free_count from sba_device Anup Patel
2017-08-01 10:37 ` [PATCH v2 07/16] dmaengine: bcm-sba-raid: Allow arbitrary number free sba_request Anup Patel
2017-08-01 10:37 ` [PATCH v2 08/16] dmaengine: bcm-sba-raid: Increase number of " Anup Patel
2017-08-01 10:37 ` [PATCH v2 09/16] dmaengine: bcm-sba-raid: Improve sba_issue_pending() run duration Anup Patel
2017-08-17 6:36 ` Vinod Koul
2017-08-18 6:12 ` Anup Patel
2017-08-01 10:37 ` [PATCH v2 10/16] dmaengine: bcm-sba-raid: Alloc resources before registering DMA device Anup Patel
2017-08-17 6:38 ` Vinod Koul [this message]
2017-08-18 5:01 ` Anup Patel
2017-08-01 10:37 ` [PATCH v2 11/16] dmaengine: bcm-sba-raid: Peek mbox when we have no free requests Anup Patel
2017-08-17 6:40 ` Vinod Koul
2017-08-18 11:36 ` Anup Patel
2017-08-01 10:37 ` [PATCH v2 12/16] dmaengine: bcm-sba-raid: Pre-ack async tx descriptor Anup Patel
2017-08-01 10:37 ` [PATCH v2 13/16] dmaengine: bcm-sba-raid: Re-factor sba_process_deferred_requests() Anup Patel
2017-08-01 10:37 ` [PATCH v2 14/16] dmaengine: bcm-sba-raid: Remove redundant SBA_REQUEST_STATE_RECEIVED Anup Patel
2017-08-01 10:37 ` [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Anup Patel
2017-08-17 8:01 ` Vinod Koul
2017-08-18 5:03 ` Anup Patel
2017-08-18 5:26 ` Vinod Koul
2017-08-18 5:25 ` Anup Patel
2017-09-07 19:37 ` Greg KH
2017-09-08 4:09 ` Vinod Koul
2017-08-01 10:38 ` [PATCH v2 16/16] dmaengine: bcm-sba-raid: Explicitly ACK mailbox message after sending Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817063812.GA3053@localhost \
--to=vinod.koul@intel.com \
--cc=anup.patel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).