From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753397AbdHQPLX (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 Aug 2017 11:11:23 -0400
Received: from mail-pg0-f65.google.com ([74.125.83.65]:33147 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752984AbdHQPLU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Aug 2017 11:11:20 -0400
Date: Thu, 17 Aug 2017 10:11:16 -0500
From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux@roeck-us.net, jdelvare@suse.com, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org, joel@jms.id.au, jk@ozlabs.org,
        andrew@aj.id.au, mark.rutland@arm.com, devicetree@vger.kernel.org,
        corbet@lwn.net, linux-doc@vger.kernel.org,
        "Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power
 supply device
Message-ID: <20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop>
References: <1502403586-20549-1-git-send-email-eajames@linux.vnet.ibm.com>
 <1502403586-20549-2-git-send-email-eajames@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1502403586-20549-2-git-send-email-eajames@linux.vnet.ibm.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 10, 2017 at 05:19:44PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
> 
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  .../devicetree/bindings/i2c/ibm,power-ps.txt        | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> new file mode 100644
> index 0000000..2ea8ea2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> @@ -0,0 +1,21 @@
> +Device-tree bindings for IBM POWER system power supplies
> +--------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,power-ps";
> + - reg = < I2C bus address >;		: Address of the power supply on the
> +					  I2C bus.
> +
> +Example:
> +
> +    i2c-bus@100 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        #interrupt-cells = <1>;
> +        < more properties >
> +
> +        power_ps@68 {

Don't use '_' in node names. Should be a generic name too if possible. 
Perhaps "power-supply".

> +            compatible = "ibm,power-ps";
> +            reg = <0x68>;
> +        };
> +    };
> -- 
> 1.8.3.1
>