From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbdHRFXC (ORCPT ); Fri, 18 Aug 2017 01:23:02 -0400 Received: from mga03.intel.com ([134.134.136.65]:14119 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbdHRFXA (ORCPT ); Fri, 18 Aug 2017 01:23:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,391,1498546800"; d="scan'208";a="1184146744" Date: Fri, 18 Aug 2017 10:56:13 +0530 From: Vinod Koul To: Anup Patel Cc: Rob Herring , Mark Rutland , Dan Williams , Florian Fainelli , Scott Branden , Ray Jui , Linux Kernel , Linux ARM Kernel , Device Tree , dmaengine@vger.kernel.org, BCM Kernel Feedback Subject: Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Message-ID: <20170818052613.GE3053@localhost> References: <1501583880-32072-1-git-send-email-anup.patel@broadcom.com> <1501583880-32072-16-git-send-email-anup.patel@broadcom.com> <20170817080142.GC3053@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote: > On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul wrote: > > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote: > > why fail, debugfs should be an optional thingy, why would you want to fail here? > > Yes, we are handling the case when debugfs is not available > and skipping debugfs gracefully. > > If debugfs is available then failure of debugfs_create_dir() > should be reported. reported yes, bailing out on that err no.. -- ~Vinod