From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
peterz@infradead.org, acme@kernel.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org, Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings
Date: Wed, 23 Aug 2017 08:59:00 -0700 [thread overview]
Message-ID: <20170823155900.GK2482@two.firstfloor.org> (raw)
In-Reply-To: <20170823141401.GA16889@krava>
> so if I find HITM with this flag set I should count it
> as remote HITM then? something like attached.. untested
You mean for c2c? Yes looks reasonable.
-Andi
>
> thanks,
> jirka
>
> ---
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 06f5a3a4295c..65e22b9e59f9 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -279,6 +279,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
> u64 lvl = data_src->mem_lvl;
> u64 snoop = data_src->mem_snoop;
> u64 lock = data_src->mem_lock;
> + bool mr = data_src->mem_remote;
> int err = 0;
>
> #define HITM_INC(__f) \
> @@ -324,7 +325,7 @@ do { \
> }
>
> if ((lvl & P(LVL, REM_RAM1)) ||
> - (lvl & P(LVL, REM_RAM2))) {
> + (lvl & P(LVL, REM_RAM2)) || mr) {
> stats->rmt_dram++;
> if (snoop & P(SNOOP, HIT))
> stats->ld_shared++;
> @@ -334,7 +335,7 @@ do { \
> }
>
> if ((lvl & P(LVL, REM_CCE1)) ||
> - (lvl & P(LVL, REM_CCE2))) {
> + (lvl & P(LVL, REM_CCE2)) || mr) {
> if (snoop & P(SNOOP, HIT))
> stats->rmt_hit++;
> else if (snoop & P(SNOOP, HITM))
>
next prev parent reply other threads:[~2017-08-23 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 22:21 Fix Skylake PEBS data source for perf v5 Andi Kleen
2017-08-16 22:21 ` [PATCH v5 1/4] perf/x86: Move Nehalem PEBS code to flag Andi Kleen
2017-08-25 11:53 ` [tip:perf/core] " tip-bot for Andi Kleen
2017-08-16 22:21 ` [PATCH v5 2/4] perf/x86: Fix data source decoding for Skylake Andi Kleen
2017-08-25 11:53 ` [tip:perf/core] " tip-bot for Andi Kleen
2017-08-16 22:21 ` [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Andi Kleen
2017-08-23 13:01 ` Jiri Olsa
2017-08-23 14:00 ` Andi Kleen
2017-08-23 14:14 ` Jiri Olsa
2017-08-23 15:59 ` Andi Kleen [this message]
2017-08-24 8:23 ` Jiri Olsa
2017-08-24 8:23 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-16 22:21 ` [PATCH v5 4/4] perf, tools: Add test cases for new data source encoding Andi Kleen
2017-08-24 8:23 ` [tip:perf/core] perf test: " tip-bot for Andi Kleen
2017-08-22 15:37 ` Fix Skylake PEBS data source for perf v5 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823155900.GK2482@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).