linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Tom Rini <trini@konsulko.com>
Cc: linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Wed, 23 Aug 2017 23:47:52 +0100	[thread overview]
Message-ID: <20170823224752.p3ebgenlnstkd5jg@sirena.org.uk> (raw)
In-Reply-To: <20170823223524.GW17193@bill-the-cat>

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

On Wed, Aug 23, 2017 at 06:35:24PM -0400, Tom Rini wrote:

> After looking at 89128534f925 (which introduced the above line, and thus

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

> support for the Chromebook), I think that 36afb0ab648 and 55e59aa0525a
> are wrong and should be reverted.  It seems like they're an attempt to
> make 89128534f925 be done 'properly' but it also seems like the

Please be more specific.  The only obvious issue with the original patch
"ASoC: rt5677: Add ACPI support" is that it adds an I2C ID instead of an
ACPI ID.  I don't have 36afb0ab648 so I've no idea what it is and
55e59aa0525a is "ASoC: rt5677: Move platform code to board file" which
is a code motion patch and looks more like stylistic faff around the
shambles that is ACPI than anything else.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2017-08-23 22:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  1:51 [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini
2017-08-23  9:28 ` Mark Brown
2017-08-23 22:35   ` Tom Rini
2017-08-23 22:47     ` Mark Brown [this message]
2017-08-23 22:54       ` Tom Rini
2017-08-23 23:15         ` Mark Brown
2017-08-23 23:02       ` Mark Brown
2017-08-23 14:29 ` Andy Shevchenko
2017-08-23 17:39   ` Tom Rini
2017-08-24  0:05     ` Tom Rini
2017-08-24  7:39       ` Andy Shevchenko
2017-08-24 11:15         ` Tom Rini
2017-08-24 12:26           ` Andy Shevchenko
2017-08-24 13:41             ` Mark Brown
2017-08-24 13:47             ` Tom Rini
2017-08-24 14:28       ` [alsa-devel] " Takashi Iwai
2017-08-24 14:31         ` Takashi Iwai
2017-08-24 14:41           ` Tom Rini
2017-08-24 15:42             ` Takashi Iwai
2017-08-24 15:52               ` Mark Brown
2017-08-24 15:54                 ` Takashi Iwai
2017-08-24 15:54                 ` Tom Rini
2017-08-24 16:06                   ` Takashi Iwai
2017-08-24 16:08                     ` Tom Rini
2017-08-24 17:16                     ` Andy Shevchenko
2017-08-24 17:44                       ` Takashi Iwai
2017-08-25 13:48                         ` Mark Brown
2017-08-25 13:09                     ` Mark Brown
2017-08-25 13:17                       ` Takashi Iwai
2017-08-25 13:56 ` Andy Shevchenko
2017-08-25 14:24   ` Tom Rini
2017-08-25 14:49     ` Andy Shevchenko
2017-08-25 16:05     ` John Keeping
2017-08-25 16:42       ` Andy Shevchenko
2017-08-25 17:09         ` John Keeping
2017-08-25 19:33         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823224752.p3ebgenlnstkd5jg@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bardliao@realtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=torvalds@linux-foundation.org \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).