From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753842AbdHXQx5 (ORCPT ); Thu, 24 Aug 2017 12:53:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:48888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbdHXQxz (ORCPT ); Thu, 24 Aug 2017 12:53:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E1421A1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Thu, 24 Aug 2017 11:53:54 -0500 From: Bjorn Helgaas To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com, shawn.lin@rock-chips.com, briannorris@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq Message-ID: <20170824165353.GL31858@bhelgaas-glaptop.roam.corp.google.com> References: <20170822031934.8675-1-jeffy.chen@rock-chips.com> <20170822031934.8675-4-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822031934.8675-4-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote: > Add an optional interrupt for PCIE_WAKE pin. Rob? > Signed-off-by: Jeffy Chen > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > index 5678be82530d..9f6504129e80 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt > @@ -20,10 +20,13 @@ Required properties: > - msi-map: Maps a Requester ID to an MSI controller and associated > msi-specifier data. See ./pci-msi.txt > - interrupts: Three interrupt entries must be specified. > -- interrupt-names: Must include the following names > - - "sys" > - - "legacy" > - - "client" > +- interrupt-names: Include the following names > + Required: > + - "sys" > + - "legacy" > + - "client" > + Optional: > + - "wake" Why is there no other PCI binding that includes "wake" as an interrupt-name? This feels like something that should be fairly common across host controllers. I don't want a Rockport-specific DT description if it could be made more general. > - resets: Must contain seven entries for each entry in reset-names. > See ../reset/reset.txt for details. > - reset-names: Must include the following names > @@ -87,10 +90,11 @@ pcie0: pcie@f8000000 { > clock-names = "aclk", "aclk-perf", > "hclk", "pm"; > bus-range = <0x0 0x1>; > - interrupts = , > - , > - ; > - interrupt-names = "sys", "legacy", "client"; > + interrupts-extended = <&gic GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH 0>, > + <&gic GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH 0>, > + <&gic GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH 0>, > + <&gpio0 8 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "sys", "legacy", "client", "wake"; > assigned-clocks = <&cru SCLK_PCIEPHY_REF>; > assigned-clock-parents = <&cru SCLK_PCIEPHY_REF100M>; > assigned-clock-rates = <100000000>; > -- > 2.11.0 > >