linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Ziqian SUN (Zamir)" <zsun@redhat.com>
Cc: linux-kernel@vger.kernel.org, jkacur@redhat.com
Subject: Re: [PATCH] trace-cmd report: Fix hash.key in option -w
Date: Fri, 25 Aug 2017 10:22:29 -0400	[thread overview]
Message-ID: <20170825102229.1efedf40@gandalf.local.home> (raw)
In-Reply-To: <1503640069-23069-1-git-send-email-zsun@redhat.com>

On Fri, 25 Aug 2017 13:47:49 +0800
"Ziqian SUN (Zamir)" <zsun@redhat.com> wrote:

> From: "Ziqian SUN (Zamir)" <zsun@redhat.com>
> 
> In add_wakeup function the hash list is created with hash.key = value.
> This makes add_sched function will never find a match with the key which
> results in trace-cmd report will never show the average latency with the
> following command:
> trace-cmd report -w -F 'sched_switch,sched_wakeup'
> With this patch, the command will show average latency as it used to be
> in v2.4.2 like
> 
> Average wakeup latency: 28.460 usecs
> Maximum Latency: 669.268 usecs at timestamp: 16337.629767
> Minimum Latency: 2.153 usecs at timestamp: 16337.533735
> 
> RT task timings:
> 
> Average wakeup latency: 23.106 usecs
> Maximum Latency: 57.482 usecs at timestamp: 16337.187531
> Minimum Latency: 4.127 usecs at timestamp: 16336.945209
> 
> Reported-by: Joe Mario <jmario@redhat.com>
> Signed-off-by: Ziqian SUN (Zamir) <zsun@redhat.com>

Thanks a lot Ziqian! Added. Will push out soon.

I need to update the stables too.

-- Steve

      reply	other threads:[~2017-08-25 14:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  5:47 [PATCH] trace-cmd report: Fix hash.key in option -w Ziqian SUN (Zamir)
2017-08-25 14:22 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825102229.1efedf40@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zsun@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).