From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933495AbdHYPCX (ORCPT ); Fri, 25 Aug 2017 11:02:23 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:53818 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932326AbdHYPCW (ORCPT ); Fri, 25 Aug 2017 11:02:22 -0400 Date: Fri, 25 Aug 2017 08:02:10 -0700 From: Christoph Hellwig To: Hans de Goede Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org Subject: Re: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf) support Message-ID: <20170825150210.GB6706@infradead.org> References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-3-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825143732.10836-3-hdegoede@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please merge the files into a a lot fewer files - basically one .c file and a header for the protocol probably is enough. Also kill all kinds of weird tiny wrappers that just obsfucate the code, and make sure linux-fsdevel is on Cc for your next submission. Also don't use i_private, instead defined alloc_inode and destroy_inode methods and use container_of. > +/** > + * @note Anyone wishing to make changes here might wish to take a look at > + * http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt > + * which seems to be the closest there is to official documentation on > + * writing filesystem drivers for Linux. > + */ And drop comments like this which will create a lot more confusion than actually helping.