From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933931AbdHYPvV (ORCPT ); Fri, 25 Aug 2017 11:51:21 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:44358 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933662AbdHYPvU (ORCPT ); Fri, 25 Aug 2017 11:51:20 -0400 Date: Fri, 25 Aug 2017 17:51:11 +0200 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, nadavh@marvell.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mw@semihalf.com, stefanc@marvell.com, miquel.raynal@free-electrons.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Message-ID: <20170825155111.GD30922@lunn.ch> References: <20170825144821.31129-1-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825144821.31129-1-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - Checked if the carrier_on/off functions were needed. They are. Hi Antoine Could you explain the situations they are needed in? Quite a few drivers do this, so i'm not saying it is wrong. But it would be nice to understand if we are missing something in phylib. Andrew