From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758802AbdHYVuX (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Aug 2017 17:50:23 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:34868 "EHLO
        mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756673AbdHYVuV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Aug 2017 17:50:21 -0400
Date: Fri, 25 Aug 2017 22:50:19 +0100
From: Martyn Welch <martyn@welchs.me.uk>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: devel@driverdev.osuosl.org, Aaron Sierra <asierra@xes-inc.com>,
        Alessio Igor Bogani <alessio.bogani@elettra.eu>,
        Arnd Bergmann <arnd@arndb.de>,
        Augusto Mecking Caringi <augustocaringi@gmail.com>,
        Baoyou Xie <baoyou.xie@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Manohar Vanga <manohar.vanga@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] VME: Adjustments for several function
 implementations
Message-ID: <20170825215018.GB14783@hades.home>
References: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 25 Aug 2017 13:15:43 +0200
> 
> Several update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (14):
>   Delete 11 error messages for a failed memory allocation
>   Improve 11 size determinations
>   Move an assignment in vme_new_dma_list()
>   Adjust 48 checks for null pointers
>   Return directly in two functions
>   fake: Delete an error message for a failed memory allocation in fake_init()
>   fake: Improve five size determinations in fake_init()
>   fake: Adjust 11 checks for null pointers
>   ca91cx42: Delete eight error messages for a failed memory allocation
>   ca91cx42: Improve 12 size determinations
>   ca91cx42: Adjust 14 checks for null pointers
>   tsi148: Delete nine error messages for a failed memory allocation
>   tsi148: Improve 17 size determinations
>   tsi148: Adjust 14 checks for null pointers
> 

Hi Markus,

Thanks for the patches. Other than the minor tweak needed to patch 13,
these are looking good to me.

Martyn

>  drivers/vme/bridges/vme_ca91cx42.c |  73 +++++---------
>  drivers/vme/bridges/vme_fake.c     |  35 +++----
>  drivers/vme/bridges/vme_tsi148.c   |  82 ++++++----------
>  drivers/vme/vme.c                  | 194 ++++++++++++++++---------------------
>  4 files changed, 156 insertions(+), 228 deletions(-)
> 
> -- 
> 2.14.0
>