From: David Miller <davem@davemloft.net>
To: yanhaishuang@cmss.chinamobile.com
Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] be2net: Fix some u16 fields appropriately
Date: Mon, 28 Aug 2017 16:19:24 -0700 (PDT) [thread overview]
Message-ID: <20170828.161924.1286298670313299855.davem@davemloft.net> (raw)
In-Reply-To: <1503818685-32068-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Sun, 27 Aug 2017 15:24:45 +0800
> In be_tx_compl_process, frag_index declared as u32, so it's better to
> declare last_index as u32 also.
>
> CC: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve
> performance")
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
That is not a legitimate reason for making this change.
> @@ -255,7 +255,7 @@ struct be_tx_stats {
> /* Structure to hold some data of interest obtained from a TX CQE */
> struct be_tx_compl_info {
> u8 status; /* Completion status */
> - u16 end_index; /* Completed TXQ Index */
> + u32 end_index; /* Completed TXQ Index */
> };
>
> struct be_tx_obj {
The ->end_index comes solely from:
txcp->end_index = GET_TX_COMPL_BITS(wrb_index, compl);
Which is precisely a 16-bit value.
I'm not applying this, sorry.
next prev parent reply other threads:[~2017-08-28 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 7:24 [PATCH] be2net: Fix some u16 fields appropriately Haishuang Yan
2017-08-28 23:19 ` David Miller [this message]
2017-08-29 1:04 ` 严海双
2017-08-29 4:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828.161924.1286298670313299855.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).