From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, James Morse <james.morse@arm.com>,
"Huang, Ying" <ying.huang@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH 4.4 53/53] ACPI / APEI: Add missing synchronize_rcu() on NOTIFY_SCI removal
Date: Mon, 28 Aug 2017 10:05:58 +0200 [thread overview]
Message-ID: <20170828080520.063921327@linuxfoundation.org> (raw)
In-Reply-To: <20170828080517.599193891@linuxfoundation.org>
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: James Morse <james.morse@arm.com>
commit 7d64f82cceb21e6d95db312d284f5f195e120154 upstream.
When removing a GHES device notified by SCI, list_del_rcu() is used,
ghes_remove() should call synchronize_rcu() before it goes on to call
kfree(ghes), otherwise concurrent RCU readers may still hold this list
entry after it has been freed.
Signed-off-by: James Morse <james.morse@arm.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Fixes: 81e88fdc432a (ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/acpi/apei/ghes.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1067,6 +1067,7 @@ static int ghes_remove(struct platform_d
if (list_empty(&ghes_sci))
unregister_acpi_hed_notifier(&ghes_notifier_sci);
mutex_unlock(&ghes_list_mutex);
+ synchronize_rcu();
break;
case ACPI_HEST_NOTIFY_NMI:
ghes_nmi_remove(ghes);
next prev parent reply other threads:[~2017-08-28 8:15 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:05 [PATCH 4.4 00/53] 4.4.85-stable review Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 01/53] af_key: do not use GFP_KERNEL in atomic contexts Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 02/53] dccp: purge write queue in dccp_destroy_sock() Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 03/53] dccp: defer ccid_hc_tx_delete() at dismantle time Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 04/53] ipv4: fix NULL dereference in free_fib_info_rcu() Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 05/53] net_sched/sfq: update hierarchical backlog when drop packet Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 06/53] ipv4: better IP_MAX_MTU enforcement Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 07/53] sctp: fully initialize the IPv6 address in sctp_v6_to_addr() Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 08/53] tipc: fix use-after-free Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 09/53] ipv6: reset fn->rr_ptr when replacing route Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 10/53] ipv6: repair fib6 tree in failure case Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 11/53] tcp: when rearming RTO, if RTO time is in past then fire RTO ASAP Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 12/53] irda: do not leak initialized list.dev to userspace Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 13/53] net: sched: fix NULL pointer dereference when action calls some targets Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 14/53] net_sched: fix order of queue length updates in qdisc_replace() Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 15/53] mei: me: add broxton pci device ids Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 16/53] mei: me: add lewisburg " Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 17/53] Input: trackpoint - add new trackpoint firmware ID Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 18/53] Input: elan_i2c - add ELAN0602 ACPI ID to support Lenovo Yoga310 Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 19/53] ALSA: core: Fix unexpected error at replacing user TLV Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 20/53] ALSA: hda - Add stereo mic quirk for Lenovo G50-70 (17aa:3978) Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 21/53] ARCv2: PAE40: Explicitly set MSB counterpart of SLC region ops addresses Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 22/53] i2c: designware: Fix system suspend Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 24/53] drm/atomic: If the atomic check fails, return its value first Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 25/53] drm: rcar-du: lvds: Fix PLL frequency-related configuration Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 26/53] drm: rcar-du: lvds: Rename PLLEN bit to PLLON Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 27/53] drm: rcar-du: Fix crash in encoder failure error path Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 28/53] drm: rcar-du: Fix display timing controller parameter Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 29/53] drm: rcar-du: Fix H/V sync signal polarity configuration Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 30/53] tracing: Fix freeing of filter in create_filter() when set_str is false Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 31/53] cifs: Fix df output for users with quota limits Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 32/53] cifs: return ENAMETOOLONG for overlong names in cifs_open()/cifs_lookup() Greg Kroah-Hartman
2017-10-11 19:24 ` Ben Hutchings
2017-08-28 8:05 ` [PATCH 4.4 33/53] nfsd: Limit end of page list when decoding NFSv4 WRITE Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 34/53] perf/core: Fix group {cpu,task} validation Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 35/53] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread Greg Kroah-Hartman
2017-09-26 15:32 ` Ben Hutchings
2017-08-28 8:05 ` [PATCH 4.4 36/53] Bluetooth: cmtp: fix possible might sleep error in cmtp_session Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 37/53] Bluetooth: bnep: fix possible might sleep error in bnep_session Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 38/53] binder: use group leader instead of open thread Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 39/53] binder: Use wake up hint for synchronous transactions Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 40/53] ANDROID: binder: fix proc->tsk check Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 41/53] iio: imu: adis16480: Fix acceleration scale factor for adis16480 Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 42/53] iio: hid-sensor-trigger: Fix the race with user space powering up sensors Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 43/53] staging: rtl8188eu: add RNX-N150NUB support Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 44/53] ASoC: simple-card: dont fail if sysclk setting is not supported Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 45/53] ASoC: rsnd: disable SRC.out only when stop timing Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 46/53] ASoC: rsnd: avoid pointless loop in rsnd_mod_interrupt() Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 47/53] ASoC: rsnd: Add missing initialization of ADG req_rate Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 48/53] ASoC: rsnd: ssi: 24bit data needs right-aligned settings Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 49/53] ASoC: rsnd: dont call update callback if it was NULL Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 50/53] ntb_transport: fix qp count bug Greg Kroah-Hartman
2017-09-26 16:32 ` Ben Hutchings
2017-09-26 17:35 ` Logan Gunthorpe
2017-09-27 8:40 ` Greg Kroah-Hartman
2017-09-27 15:57 ` Logan Gunthorpe
2017-09-28 8:14 ` Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 51/53] ntb_transport: fix bug calculating num_qps_mw Greg Kroah-Hartman
2017-08-28 8:05 ` [PATCH 4.4 52/53] ACPI: ioapic: Clear on-stack resource before using it Greg Kroah-Hartman
2017-08-28 8:05 ` Greg Kroah-Hartman [this message]
2017-08-28 19:39 ` [PATCH 4.4 00/53] 4.4.85-stable review Shuah Khan
2017-08-29 0:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828080520.063921327@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).